Remove Command's knowledge of its own keybindings #17160
Labels
Area-CodeHealth
Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Issue-Task
It's a feature request, but it doesn't really need a major design.
Needs-Tag-Fix
Doesn't match tag requirements
Product-Terminal
The new Windows Terminal.
Milestone
Description of the new feature/enhancement
As we move to implementing Action IDs and referring to Commands with their IDs everywhere, it no longer makes sense for a Command to have knowledge about its own keymappings (let the Action Map handle that, especially with all the layering involved)
Proposed technical implementation details (optional)
Remove the keymappings array from
Command
, currently every place that we query a Command for its keys also has access to the ActionMap, so those places should query the ActionMap for the keys of that Command insteadThe text was updated successfully, but these errors were encountered: