Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Re-attach Tracing to UIA Tree #1914

Closed
carlos-zamora opened this issue Jul 10, 2019 · 0 comments · Fixed by #4495
Closed

Task: Re-attach Tracing to UIA Tree #1914

carlos-zamora opened this issue Jul 10, 2019 · 0 comments · Fixed by #4495
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

Summary of the new feature/enhancement

I'm removing Microsoft::Console::Interactivity::Win32::Tracings s_TraceUia() temporarilly in my Accessibility PR #1691 . I need to hook this back up. Filing this as a task.
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Jul 10, 2019
@carlos-zamora carlos-zamora self-assigned this Jul 10, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 10, 2019
@carlos-zamora carlos-zamora mentioned this issue Jul 10, 2019
Merged
4 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 10, 2019
@carlos-zamora carlos-zamora mentioned this issue Jul 17, 2019
Merged
9 tasks
@carlos-zamora carlos-zamora added this to the August Releases milestone Jul 31, 2019
@cinnamon-msft cinnamon-msft added the Help Wanted We encourage anyone to jump in on these. label Jan 23, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 6, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 6, 2020
@carlos-zamora carlos-zamora removed the Help Wanted We encourage anyone to jump in on these. label Feb 6, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
@cinnamon-msft cinnamon-msft added the Priority-1 A description (P1) label Feb 19, 2020
@ghost ghost closed this as completed in #4495 Feb 20, 2020
@ghost ghost removed the In-PR This issue has a related PR label Feb 20, 2020
ghost pushed a commit that referenced this issue Feb 20, 2020
@carlos-zamora
UIA: Fix GetVisibleRanges() and add Tracing (#4495)
360c655 
## Summary of the Pull Request
Debugging our custom UIA providers has been a painful experience because outputting content to VS may result in UIA Clients getting impatient and giving up on extracting data.

Adding tracing allows us to debug these providers without getting in the way of reproducing a bug. This will help immensely with developing accessibility features on Windows Terminal and Console.

This pull request additionally contains payload from #4526:
* Make GetVisibleRanges() return one range (and add tracing for it).
`ScreenInfoUiaProvider::GetVisibleRanges()` used to return one range per line of visible text. The documentation for this function says that we should return one per contiguous span of text. Since all of the text in the TermControl will always be contiguous (at least by our standards), we should only ever be returning one range.

## PR Checklist
* [x] Closes #1914. Closes #4507.
* [x] CLA signed

## Detailed Description of the Pull Request / Additional comments
`UiaTracing` is a singleton class that is in charge of registration for trace logging. `TextRange` is used to trace `UiaTextRange`, whereas `TextProvider` is used to trace `ScreenInfoUiaProviderBase`.

`_getValue()` is overloaded to transform complex objects and enums into a string for logging.

`_getTextValue()` had to be added to be able to trace the text a UiaTextRange included. This makes following UiaTextRanges much simpler.

## Validation Steps Performed
Performed a few operations when under NVDA/Narrator and manually checked the results.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Feb 20, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

UIA: Fix GetVisibleRanges() and add Tracing microsoft/terminal
3 participants
@carlos-zamora @DHowett-MSFT @cinnamon-msft