Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UiaTextRange - ScrollIntoView Implementation #2361

Closed
carlos-zamora opened this issue Aug 8, 2019 · 0 comments · Fixed by #4525
Closed

UiaTextRange - ScrollIntoView Implementation #2361

carlos-zamora opened this issue Aug 8, 2019 · 0 comments · Fixed by #4525
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

ConHost's UiaTextRange allows you to scroll into another viewport (UiaTextRange::ScrollIntoView()). This needs to be implemented in WindowsTerminal to allow for proper scrolling using the UIA Tree.

Proposed technical implementation details (optional)

After refactoring the UIA Providers (ScreenInfoUiaProvider and UiaTextRange) into a better separated model (#2120), the location for this implementation is a lot clearer. There's an associated TODO in TermControl -> UiaTextRange.cpp.
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 8, 2019
@carlos-zamora carlos-zamora added this to the Terminal 1908.1 milestone Aug 8, 2019
@carlos-zamora carlos-zamora self-assigned this Aug 8, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 8, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 8, 2019
@cinnamon-msft cinnamon-msft added Priority-0 Bugs that we consider release-blocking/recall-class (P0) v1-Scrubbed labels Jan 23, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 11, 2020
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
DHowett-MSFT pushed a commit that referenced this issue Feb 11, 2020
@carlos-zamora
uia: add support for scrolling the viewport (#4525)
be614c2 
The UIA Provider now scrolls the viewport when necessary. This just fills in the missing virtual function in Terminal to have the same behavior as what it does in ConHost.

* [X] Closes #2361 
* [X] CLA signed.

`ChangeViewport` is now a virtual function at the `ScreenInfoUiaProvider` layer to have access to the TermControl.

In ConHost, we pass this call up to the WindowUiaProvider layer. In Terminal, we don't need to do that because the concept of updating the viewport is handled at the TermControl layer. So we just call that function and _voila_!
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

uia: add support for scrolling the viewport microsoft/terminal
3 participants
@carlos-zamora @DHowett-MSFT @cinnamon-msft