-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorScheme.background is ignored #2883
Comments
Right now, the order is scheme, profile ... with the added caveat that profile background from defaults.json overrides a scheme set in profiles.json. Can you try adding |
@DHowett yeah null works as well |
Can I configure this terminal to run it quickly? for example when I press windows key + r "cmd"? |
@RafaelPuerta quick question: why would you ask about that on a random bug report about color schemes and backgrounds? |
Experiencing this issue since the latest update as well. |
@RLgod and did the same remediation work in your case? |
Yeh adding |
Okay so the fix for this is that we need to make sure that when the user's settings has a colorscheme set, we clear out the foreground/background for that profile as well. |
Better fix: Introduce a defaults.json color scheme called |
+1 on this. The suggestions work but they aren't fixes, they are just workarounds for an issue that should be fixed. |
This ended up working for me thanks @DHowett-MSFT |
🎉This issue was addressed in #2936, which has now been successfully released as Handy links: |
Steps to reproduce
Expected behavior
The background color should be Dracula's black (
#282A36
).Actual behavior
The background color for the Windows PowerShell profile is still the default PowerShell dark blue, even though Dracula is the active color scheme.
Workaround
My current workaround is to additionally specify the background in the profile itself. It seems to me like this is an issue of precedence--the background in the colorscheme should override any global defaults for a given shell.
profiles.json:
The text was updated successfully, but these errors were encountered: