Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving focus between panes doesn't always work #3045

Closed
zadjii-msft opened this issue Oct 3, 2019 · 5 comments · Fixed by #3958
Closed

Moving focus between panes doesn't always work #3045

zadjii-msft opened this issue Oct 3, 2019 · 5 comments · Fixed by #3958
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

Messing around with panes today, and found it wasn't walways possible to move focus correctly. This was the setup:

image

I believe the tree was like this:


  +--------------------------------------------------------------+
  | +---------------------------+ +----------------------------+ |
  | | +----------+ +----------+ | | +------------------------+ | |
  | | |          | | +------+ | | | |                        | | |
  | | |          | | |      | | | | |                        | | |
  | | |          | | |  2   | | | | |             4          | | |
  | | |          | | |      | | | | |                        | | |
  | | |    1     | | +------+ | | | |                        | | |
  | | |          | |          | | | +------------------------+ | |
  | | |          | | +------+ | | | +------------------------+ | |
  | | |          | | |      | | | | | +--------------------+ | | |
  | | |          | | |      | | | | | |          5         | | | |
  | | |          | | |  3   | | | | | +--------------------+ | | |
  | | |          | | |      | | | | | +--------------------+ | | |
  | | |          | | |      | | | | | |          6         | | | |
  | | |          | | +------+ | | | | +--------------------+ | | |
  | | +----------+ +----------+ | | +------------------------+ | |
  | +---------------------------+ +----------------------------+ |
  +--------------------------------------------------------------+

Actual

Moving from (2,3) -> 4 was NOT possible.

Expected

Moving from (2,3) -> 4 was possible.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Oct 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Oct 3, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 3, 2019
@DHowett-MSFT
Copy link
Contributor

Related: #2398

@zadjii-msft zadjii-msft mentioned this issue Oct 4, 2019
Open
59 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 7, 2019
@eduardonunesp
Copy link

eduardonunesp commented Oct 31, 2019 •
edited
Loading

How to open panes like that I didn't find any command like newPane

@zadjii-msft
Copy link
Member Author

@eduardonunesp I'd refer you to #1000 (comment)

@jwhipp
Copy link

jwhipp commented Nov 21, 2019

I've tried this and I have been able to move between panes with clicks but it doesn't always select. Sometimes a single click is enough, other times I have to click a bunch of times or select something in the pane to get to take focus.

@Daniel599 Daniel599 mentioned this issue Dec 13, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 13, 2019
@ghost ghost closed this as completed in #3958 Dec 16, 2019
ghost pushed a commit that referenced this issue Dec 16, 2019
@Daniel599
Fix move focus between grouped panes (#3045) (#3958)
dccb297 
This PR fixes the ability to move between already-split panes
## Summary of the Pull Request

## PR Checklist
* [x] Closes #3045
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Requires documentation to be updated
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed
Tested manually.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 16, 2019
@ghost
Copy link

ghost commented Jan 14, 2020

🎉This issue was addressed in #3958, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Fix move focus between grouped panes (#3045)
4 participants
@jwhipp @eduardonunesp @DHowett-MSFT @zadjii-msft