ANSI sequence rendered differently: \u001b[0m\u001b[7m\u001b[1m\u001b[32m PASS \u001b[39m\u001b[22m\u001b[27m\u001b[0m

[be5invis]

Environment

Windows build number: 18362.418
Windows Terminal version: 0.5.2762.0

Steps to reproduce

• Install Node.js
• Run this command in Node.js repl: console.log('\u001b[0m\u001b[7m\u001b[1m\u001b[32m PASS \u001b[39m\u001b[22m\u001b[27m\u001b[0m')

Expected behavior

A PASS is shown in black text and green background.

Actual behavior

In Windows terminal, PASS is shown in dark gray text rather than black. In the old console it is shown in black.

[DHowett-MSFT]

I believe this is a version of #293 or #2661. More likely 2661, but I can't get my debug tap working at the moment.

[j4james]

Looking at this in the debugger, I can see the attributes coming through as:

\x1b[1m\x1b[30m\x1b[102m

So in one sense it has got the colors correct, sending through a black foreground with a bright green background, but it also includes the bold attribute, which then ends up making the foreground bright as well.

[DHowett-MSFT]

Really, this should come out of ConPTY as 1;7;40;92 instead of 30;102 (#2661)... but it looks like we should at the very least suppress the brightness of the foreground when we make the bright foreground the background.

Since we don't support separate bold and bright, that'll also knock the bold attribute off ☹️

[DHowett-MSFT]

More I think about this the closer I am to calling it a /dupe of #2661. Thanks again!

[ghost]

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!