Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message badge display under Windows Terminal. #9057

Closed
wants to merge 2 commits into from
Closed

Fix message badge display under Windows Terminal. #9057

wants to merge 2 commits into from

Conversation

be5invis
Copy link

Summary

In Windows Terminal, current Jest badges does not correctly display due to the Chalk call it used: chalk.reset.inverse.bold.<color>, etc. See microsoft/terminal#3201 for more detail.

This change changes the Chalk call to chalk.reset.inverse.<color>Bright to avoid this problem.

Test plan

Run the jest test under Windows Terminal, and the PASS/FAIL badge should have black text rather than gray.

@codecov-io
Copy link

codecov-io commented Oct 16, 2019

Codecov Report

Merging #9057 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9057   +/-   ##
=======================================
  Coverage   64.07%   64.07%           
=======================================
  Files         277      277           
  Lines       11679    11679           
  Branches     2863     2863           
=======================================
  Hits         7483     7483           
  Misses       3572     3572           
  Partials      624      624
Impacted Files Coverage Δ
packages/jest-reporters/src/get_result_header.ts 47.61% <ø> (ø) ⬆️
packages/jest-reporters/src/Status.ts 80.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74da1a...11bc8dc. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Oct 16, 2019

This looks very different on Mac (iTerm) at least, so I don't think we can merge this as is.

const chalk = require('chalk');

console.log('current colors:');
console.log(chalk.reset.inverse.bold.red(' FAIL '));
console.log(chalk.reset.inverse.bold.green(' PASS '));
console.log(chalk.reset.inverse.bold.yellow(' RUNS '));

console.log('suggested colors:');
console.log(chalk.reset.inverse.redBright(' FAIL '));
console.log(chalk.reset.inverse.greenBright(' PASS '));
console.log(chalk.reset.inverse.yellowBright(' RUNS '));

image

Granted, this is color scheme specific, but it's not the same color. Also we do want the the text to be bold

@be5invis be5invis closed this Oct 19, 2019
@be5invis
Copy link
Author

Close so far, throw back to CONPTY team

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants