Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not possible to scroll tabs list without touch screen #444

Closed
matthew4850 opened this issue May 6, 2019 · 10 comments · Fixed by #3027
Closed

It is not possible to scroll tabs list without touch screen #444

matthew4850 opened this issue May 6, 2019 · 10 comments · Fixed by #3027
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@matthew4850
Copy link
Contributor

  • Your Windows build number: 10.0.18890.1000

  • What you're doing and what's happening: If you open enough tabs you are unable to see all tabs at once. The only way to solve this is to either close this or use a touch screen to scroll horizontally.

  • What's wrong / what should be happening instead: It should be possible to scroll tabs without a touch screen or the tabs should automatically resize so they all fit at once.

@kumarharsh
Copy link

I think the tabs should resize to a particular min-width, and then start scrolling. Basically, the tab behaviour should be like Firefox and not Chrome.

@zadjii-msft
Copy link
Member

So there's a LOT of different opinions about how tabs should be sized. I'm not even going to open that can of worms here.

What I can say is that mouse scrolling of the tabs _should_work. Unfortunately, we're using a pretty early build of the TabControl, so when you try scrolling it with the mouse, the parts of the tabs that weren't visible before don't actually render for some reason. If you manually resize the window, then the tabs will figure themselves out.

@zadjii-msft zadjii-msft added Issue-Question For questions or discussion Resolution-External For issues that are outside this codebase labels May 7, 2019
@krzys-h
Copy link

krzys-h commented May 7, 2019

I can confirm that scrolling the tab list with does not seem to work at all for me either. I don't have a touch screen to test.

Windows build 10.0.18362.86

@pkarakal
Copy link

pkarakal commented May 8, 2019

Scrolling works with a mouse but not as intended. When I open many terminal tabs as can be seen in the screenshot below, it doesn't show the complete tab and when I open more tabs, they don't even appear in the bar. (the maximum number of tabs are 4)
Also scrolling works with a mouse but not with Windows Precision trackpad.

@matthew4850
Copy link
Contributor Author

Ah, I was using my surfaces trackpad

@Californ1a
Copy link

@kumarharsh commented on May 6, 2019, 11:53 PM EDT:

I think the tabs should resize to a particular min-width, and then start scrolling. Basically, the tab behaviour should be like Firefox and not Chrome.

@zadjii-msft commented on May 7, 2019, 12:56 PM EDT:

So there's a LOT of different opinions about how tabs should be sized. I'm not even going to open that can of worms here.

Might be better suited as a separate issue, but since it came up in here, what about a setting for minimum tab width instead of forcing either "scrolling after min-width" or "no min-width, no scroll" tabs:

If disabled, it would be chrome-like with tabs getting ever smaller, and if enabled, then you can define the min-width you want before it starts scrolling.

@matthew4850
Copy link
Contributor Author

@Californ1a yeah, that sounds like a good solution.

@zadjii-msft
Copy link
Member

@Californ1a Let's open a separate issue for discussion of tab sizing. I'd rather each issue discussed an atomic topic, in this case, scrolling the tabs without a touchscreen.

@pkarakal
Copy link

pkarakal commented May 9, 2019

Ah, I was using my surfaces trackpad

I rebuilt it and deployed it again and it works 😉

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Mass-Chaos labels May 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 18, 2019
@ghost ghost added the In-PR This issue has a related PR label Oct 2, 2019
DHowett-MSFT pushed a commit that referenced this issue Oct 15, 2019
* We had to move to the final API:
   * Items -> TabItems
   * Items.VectorChanged -> TabItemsChanged
   * TabClose -> TabCloseRequested
   * TabViewItem.Icon -> TabViewItem.IconSource
* TabRowControl has been converted to a ContentPresenter, which
  simplifies its logic a little bit.
* TerminalPage now differentiates MUX and WUX a little better
* Because of the change from Icon to IconSource in TabViewItem,
  Utils::GetColoredIcon needed to be augmented to support MUX IconSources.
  It was still necessary to use for WUX, so it's been templatized.
* I moved us from WUX SplitButton to MUX SplitButton and brought the
  style in line with the one typically provided by TabView.
* Some of our local controls have had their backgrounds removed so
  they're more amenable to being placed on other surfaces.
* I'm suppressing the TabView's padding.
* I removed a number of apparently dead methods from App.
* I've simplified the dragbar's sizing logic and eventing.
* The winmd harvester needed to be taught to not try to copy winmds for
  framework packages.
* We now only initialize the terminal once we know the size

Closes #1896.
Closes #444.
Closes #857.
Closes #771.
Closes #760.
@ghost ghost removed the In-PR This issue has a related PR label Oct 15, 2019
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Oct 15, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

🎉This issue was addressed in #3027, which has now been successfully released as Windows Terminal Preview v0.6.2951.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-External For issues that are outside this codebase Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants