Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decreasing the width of vim.exe corrupts buffer #5428

Closed
zadjii-msft opened this issue Apr 20, 2020 · 0 comments · Fixed by #5449
Closed

Decreasing the width of vim.exe corrupts buffer #5428

zadjii-msft opened this issue Apr 20, 2020 · 0 comments · Fixed by #5449
Assignees
@zadjii-msft
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@zadjii-msft
Copy link
Member

Dragging vim.exe across the DPI boundary to a 100% scale display corrupts the first line of the buffer - maybe related to #5398?

Probably not related to #5398, but generally #5181/#5294. I'd bet it repros in master too. The exact repro is:

  1. Open vim.exe with no profile
  2. Create a file with two lines: "aaa" and "bbb". I didn't have a trailing blank line.
  3. Move the cursor to the 'a' in the first column, so the cursor is at 0,0.
  4. Decrease the width of the buffer by one char.

At this point, the buffer will get corrupted. The "aaa" line will be in the scrollback, we'll have two "bbb" lines in vim, but the conpty will have the correct text.

Found during #5345/#5427. I also had #5398 merged into my branch at the time.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 20, 2020
@zadjii-msft zadjii-msft self-assigned this Apr 20, 2020
@zadjii-msft zadjii-msft added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Apr 20, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 20, 2020
@miniksa miniksa mentioned this issue Apr 20, 2020
Merged
9 tasks
zadjii-msft added a commit that referenced this issue Apr 21, 2020
@zadjii-msft
I believe this is a test for #5428
a53638a
@zadjii-msft zadjii-msft mentioned this issue Apr 21, 2020
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 21, 2020
@ghost ghost closed this as completed in #5449 Apr 22, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 22, 2020
ghost pushed a commit that referenced this issue Apr 22, 2020
@zadjii-msft
Add a test to cover #5428 (#5449)
f7e2159 
This PR adds a test for #5428. Mysteriously, after #5398 merged, 5428 went away. However, I already wrote this test for it, so we might as well add it to our collection.

* [x] Closes #5428
* [x] I work here
* [x] Is a test
@zadjii-msft zadjii-msft mentioned this issue May 12, 2020
Open
31 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a test to cover #5428 microsoft/terminal
1 participant
@zadjii-msft