Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell extension should, perhaps, have an icon #6246

Closed
DHowett opened this issue May 28, 2020 · 2 comments · Fixed by #8068
Closed

Shell extension should, perhaps, have an icon #6246

DHowett opened this issue May 28, 2020 · 2 comments · Fixed by #8068
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@DHowett
Copy link
Member

DHowett commented May 28, 2020 •
edited by zadjii-msft
Loading

There's an API for it, so we might be able to do it easily.

Mike edit: context menu, explorer, "Open Windows Terminal here"
@DHowett DHowett added Help Wanted We encourage anyone to jump in on these. Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-ShellExtension For issues related to the explorer right-click context menu labels May 28, 2020
@DHowett DHowett added this to the Terminal v1.x milestone May 28, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 28, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 28, 2020
@zadjii-msft zadjii-msft mentioned this issue Jun 18, 2020
Closed
@miniksa miniksa added Area-ShellExtension For issues related to the explorer right-click context menu and removed Area-ShellExtension For issues related to the explorer right-click context menu labels Jun 19, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 19, 2020
@DHowett DHowett mentioned this issue Jun 29, 2020
Merged
3 tasks
@felipecrs felipecrs mentioned this issue Jul 11, 2020
Closed
@DHowett DHowett mentioned this issue Oct 28, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 28, 2020
@ghost ghost closed this as completed in #8068 Oct 28, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 28, 2020
ghost pushed a commit that referenced this issue Oct 28, 2020
@DHowett
Shell extension: Use WT's icon as our icon (#8068)
e21f9f5 
This is cheaper than storing another icon in another resource fork.

Eventually, we could support high contrast just by varying the icon ID.

Fixes #6246. Looks pretty good, too.

![image](https://user-images.githubusercontent.com/189190/97379930-38f08000-1883-11eb-8d37-a7741ea55b29.png)
DHowett added a commit that referenced this issue Nov 3, 2020
@DHowett
Shell extension: Use WT's icon as our icon (#8068)
952f5b1 
This is cheaper than storing another icon in another resource fork.

Eventually, we could support high contrast just by varying the icon ID.

Fixes #6246. Looks pretty good, too.

![image](https://user-images.githubusercontent.com/189190/97379930-38f08000-1883-11eb-8d37-a7741ea55b29.png)

(cherry picked from commit e21f9f5)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8068, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8068, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ShellExtension For issues related to the explorer right-click context menu Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Shell extension: Use WT's icon as our icon microsoft/terminal
4 participants
@DHowett @miniksa @zadjii-msft @cinnamon-msft