Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Tab Color Picker should be navigable with the arrow keys #6675

Closed
zadjii-msft opened this issue Jun 25, 2020 · 3 comments · Fixed by #9144
Closed

The Tab Color Picker should be navigable with the arrow keys #6675

zadjii-msft opened this issue Jun 25, 2020 · 3 comments · Fixed by #9144
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

Especially following #6567 (and moreso following #6635).

Once we open the picker, I want to be able to navigate the buttons with the arrow keys, and then hit enter to select a color.

You can cycle through the entire list with tab, but the arrow keys seem like they'd be more intuitive IMO.
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Jun 25, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Jun 25, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 25, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 25, 2020
@zadjii-msft zadjii-msft mentioned this issue Aug 26, 2020
Closed
@zadjii-msft zadjii-msft changed the title The Tab Color Picker should be navigatable with the arrow keys The Tab Color Picker should be navigable with the arrow keys Aug 26, 2020
@zadjii-msft zadjii-msft added the good first issue This is a fix that might be easier for someone to do as a first contribution label Feb 9, 2021
@BenConstable9
Copy link
Contributor

Hello @zadjii-msft, I have implemented this as was looking for a very easy starter to do. I will submit a PR.

@BenConstable9 BenConstable9 mentioned this issue Feb 13, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Feb 13, 2021
@ghost ghost closed this as completed in #9144 Feb 16, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 16, 2021
ghost pushed a commit that referenced this issue Feb 16, 2021
@BenConstable9
Add Keyboard Navigation To Color Picker (#9144)
ca226d6 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

Add the keyboard navigation to the color picker. 
Test manually.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #6675
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

Tested manually
DHowett pushed a commit that referenced this issue Feb 23, 2021
@BenConstable9 @DHowett
Add Keyboard Navigation To Color Picker (#9144)
d7fcc56 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request

Add the keyboard navigation to the color picker.
Test manually.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? -->
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #6675
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

Tested manually

(cherry picked from commit ca226d6)
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9144, which has now been successfully released as Windows Terminal v1.6.10571.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #9144, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Add Keyboard Navigation To Color Picker
3 participants
@DHowett @BenConstable9 @zadjii-msft