Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Highlight all finding #7561

Closed
krispetkov opened this issue Sep 8, 2020 · 3 comments · Fixed by #16227
Closed

Feature Request: Highlight all finding #7561

krispetkov opened this issue Sep 8, 2020 · 3 comments · Fixed by #16227
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@krispetkov
Copy link

Description of the new feature/enhancement

A good and handy feature will be the option to highlight all the find when using the ctrl+shift+f
Something like the GitBash alt+f3 search option:

2020-09-08_16-01-42

This is really helpful when looking for something or doing some comparison
@krispetkov krispetkov added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 8, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 8, 2020
@WSLUser
Copy link
Contributor

WSLUser commented Sep 8, 2020 •
edited
Loading

I actually like how the terminal scrolls to the next selection when searching a term but this can be useful too. Can this be an optional sub-setting?

@zadjii-msft
Copy link
Member

Linking this to #3920. Thanks!

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Sep 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 9, 2020
@zadjii-msft zadjii-msft mentioned this issue Sep 9, 2020
Open
20 tasks
@DHowett DHowett added this to the Terminal v2.0 milestone Sep 10, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 10, 2020
@Don-Vito Don-Vito mentioned this issue Dec 26, 2020
Closed
@skyline75489 skyline75489 mentioned this issue Apr 27, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Mar 28, 2022
Open
37 tasks
@mjclancyau

This comment was marked as spam.

Sign in to view
@j4james j4james mentioned this issue Mar 19, 2023
Closed
@zadjii-msft zadjii-msft mentioned this issue Oct 11, 2023
Closed
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
a2e676c 
microsoft#7561
Follows the existing selection code as much as possible.
@e82eric e82eric mentioned this issue Oct 25, 2023
Merged
4 tasks
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
9848703 
microsoft#7561
Follows the existing selection code as much as possible.
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
021a369 
microsoft#7561
Follows the existing selection code as much as possible.
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
577bcc0 
microsoft#7561
Follows the existing selection code as much as possible.
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
d8c0771 
microsoft#7561
Follows the existing selection code as much as possible.
e82eric added a commit to e82eric/terminal that referenced this issue Oct 25, 2023
@e82eric
Update to highlight all search results
8a5dfc6 
microsoft#7561
Follows the existing selection code as much as possible.
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Nov 27, 2023
DHowett pushed a commit that referenced this issue Dec 15, 2023
@e82eric @lhecker
Highlight all search results while the search box is open (#16227)
28acc10 
**FIRST TIME CONTRIBUTOR**

Follows the existing selection code as much as possible.
Updated logic that finds selection rectangles to also identify search
rectangles.

Right now, this feature only works in the new Atlas engine -- it uses
the background and foreground color bitmaps to quickly and efficiently
set the colors of a whole region of text.

Closes #7561

Co-authored-by: Leonard Hecker <lhecker@microsoft.com>
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Highlight all search results while the search box is open e82eric/terminal
6 participants
@DHowett @krispetkov @mjclancyau @zadjii-msft @WSLUser and others