Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line flag to start in focus mode #7875

Closed
isolune opened this issue Oct 9, 2020 · 6 comments · Fixed by #7873
Closed

Add command line flag to start in focus mode #7875

isolune opened this issue Oct 9, 2020 · 6 comments · Fixed by #7873
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@isolune
Copy link

isolune commented Oct 9, 2020 •
edited
Loading

Description of the new feature/enhancement

#6804 made it possible to strip the terminal of window decorations with the toggleFocusMode command.

It would be nice to invoke the terminal with this behavior already applied.

Proposed technical implementation details

A simple command line flag like:

wt.exe --focus-mode

to simplify the process:

wt.exe
*wait for terminal window to open*
*open command palette or press keybinding to start focus mode*
@isolune isolune added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Oct 9, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 9, 2020
@ghost
Copy link

ghost commented Oct 10, 2020 •
edited by ghost
Loading

possible duplicate of #7825

@ghost
Copy link

ghost commented Oct 10, 2020

Being tracked in #4632

@Don-Vito
Copy link
Contributor

Duplicate of #7825

@alannt777 - I am not sure this is exact duplicate: in this ticket there is a request for command line argument, while in #7825 the request is for launchMode setting (the fix for which is in PR: #7873)

@ghost
Copy link

ghost commented Oct 10, 2020

@Don-Vito

In #4632

Add command-line option start terminal in focus mode (after/during #7825)

@Don-Vito
Copy link
Contributor

@Don-Vito

In #4632

Add command-line option start terminal in focus mode (after/during #7825)

@alannt777 - absolutely agree, that #4632 mentions a command-line option, and this one is definitely duplicate to it.

Just mentioned that this is not duplicate of #7825 (so this one will not be closed by mistake when #7825 gets closed).

@isolune isolune closed this as completed Oct 10, 2020
@Don-Vito Don-Vito mentioned this issue Oct 10, 2020
Merged
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 14, 2020
ghost pushed a commit that referenced this issue Oct 14, 2020
@Don-Vito
7124: Add focus and maximizedFocus launch modes (#7873)
f86045e 
This commit introduces two new launch modes: focus and maximizedFocus. 
* Focused mode, behaves like a default mode, but with the Focus Mode
  enabled.
* Maximized focused mode, behaves like a Maximized mode, but with the
  Focus Mode enabled.

There two ways to invoke these new modes:
* In the settings file: you set the "launchMode" to either "focus" or
  "maximizedFocus"
* In the command line options, you can path -f / --focus, which is
  mutually exclusive with the --fullscreen, but can be combined with the
  --maximized:
  * Passing -f / --focus will launch the terminal in the "focus" mode
  * Passing -fM / --focus --maximized will launch the terminal in the
    "maximizedFocus" mode

This should resolve a relevant part in the command line arguments
mega-thread #4632

Closes #7124
Closes #7825
Closes #7875
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7873, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7124: Add focus and maximizedFocus launch modes Don-Vito/terminal
2 participants
@Don-Vito @isolune