Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette: page up/down "wrap" backwards when you're too close to the bottom of the list #8189

Closed
DHowett opened this issue Nov 7, 2020 · 7 comments · Fixed by #8190
Closed

Command Palette: page up/down "wrap" backwards when you're too close to the bottom of the list #8189

DHowett opened this issue Nov 7, 2020 · 7 comments · Fixed by #8190
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@DHowett
Copy link
Member

DHowett commented Nov 7, 2020

We may need to clamp the index when moving down/up.

A video of me reproducing the issue.

/cc @Hegunumo
@DHowett DHowett added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) good first issue This is a fix that might be easier for someone to do as a first contribution labels Nov 7, 2020
@DHowett DHowett added this to the Terminal v1.5 milestone Nov 7, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 7, 2020
@DHowett DHowett modified the milestones: Terminal v1.5, Terminal v2.0 Nov 7, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 7, 2020
@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 7, 2020

@DHowett - I was sure it was a feature when it was released 😄

@Don-Vito Don-Vito mentioned this issue Nov 7, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Nov 7, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

Sorry I didn’t notice that.

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 8, 2020 •
edited
Loading

@Hegunumo - please ignore my PR - it is quick and dirty. I will gladly abandon it if you plan to working on this in the future.

@ghost
Copy link

ghost commented Nov 8, 2020 •
edited by ghost
Loading

@Don-Vito - Oh it's fine. You don't need to abandon it 😊

@Don-Vito
Copy link
Contributor

Don-Vito commented Nov 8, 2020 •
edited
Loading

@Don-Vito - Oh it's fine. You don't need to abandon it 😊

@Hegunumo - Then may I ask you to help reviewing it? 😊

@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 9, 2020
DHowett pushed a commit that referenced this issue Nov 9, 2020
@Don-Vito
Teach the command palette to clamp its indices on page up/down (#8190)
624d07f 
This commit will teach CommandPalette to clamp the scroll page up and
scroll page down navigation so as to not wrap.

Closes #8189
DHowett pushed a commit that referenced this issue Nov 9, 2020
@Don-Vito @DHowett
Teach the command palette to clamp its indices on page up/down (#8190)
744631a 
This commit will teach CommandPalette to clamp the scroll page up and
scroll page down navigation so as to not wrap.

Closes #8189

(cherry picked from commit 624d07f)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8190, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8190, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Teach the command palette to clamp its indices on page up/down Don-Vito/terminal
2 participants
@DHowett @Don-Vito