Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Enable default theme based on elevation status #8311

Open
cessna048 opened this issue Nov 17, 2020 · 5 comments
Open

Suggestion: Enable default theme based on elevation status #8311

cessna048 opened this issue Nov 17, 2020 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-Theming Anything related to the theming of elements of the window Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@cessna048
Copy link

This would allow you to have a different default scheme when you are running WT as admin that when running it normally so you could visually distinguish elevated terminals. My Powershell profile sets the background to red for elevated instances but in WT the Powershell background color scrolls away or goes away completely if I use the cls command. I can set the color scheme or theme manually after opening WT but it would be nice for WT to do this automatically.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 17, 2020
@DHowett
Copy link
Member

DHowett commented Nov 18, 2020 •
edited by zadjii-msft
Loading

Thanks for the request! We're tracking this with dup #1939.

@ghost

This comment has been minimized.

Sign in to view
@ghost ghost closed this as completed Nov 18, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 18, 2020
@zadjii-msft zadjii-msft mentioned this issue Dec 1, 2020
Merged
7 tasks
zadjii-msft added a commit that referenced this issue Aug 25, 2021
@zadjii-msft
Spec for Elevation QOL improvements (#8455)
f7b0f74 
### ⇒ [doc link](https://github.com/microsoft/terminal/blob/dev/migrie/s/1032-elevation-qol/doc/specs/%235000%20-%20Process%20Model%202.0/%231032%20-%20Elevation%20Quality%20of%20Life%20Improvements.md) ⇐


## Summary of the Pull Request

Despite my best efforts to mix elevation levels in a single Terminal window, it seems that there's no way to do that safely. With the dream of mixed elevation dead, this spec outlines a number of quality-of-life improvements we can make to the Terminal today. These should make using the terminal in elevated scenarios better, since we can't have M/E.

### Abstract

> For a long time, we've been researching adding support to the Windows Terminal
> for running both unelevated and elevated (admin) tabs side-by-side, in the same
> window. However, after much research, we've determined that there isn't a safe
> way to do this without opening the Terminal up as a potential
> escalation-of-privilege vector.
> 
> Instead, we'll be adding a number of features to the Terminal to improve the
> user experience of working in elevated scenarios. These improvements include:
> 
> * A visible indicator that the Terminal window is elevated ([#1939])
> * Configuring the Terminal to always run elevated ([#632])
> * Configuring a specific profile to always open elevated ([#632])
> * Allowing new tabs, panes to be opened elevated directly from an unelevated
>   window
> * Dynamic profile appearance that changes depending on if the Terminal is
>   elevated or not. ([#1939], [#8311])


## PR Checklist
* [x] Specs: #1032, #632
* [x] References: #5000, #4472, #2227, #7240, #8135, #8311
* [x] I work here

## Detailed Description of the Pull Request / Additional comments
_\*<sup>\*</sup><sub>\*</sub> read the spec  <sub>\*</sub><sup>\*</sup>\*_

### Why are these two separate documents?

I felt that the spec that is currently in review in #7240 and this doc should remain separate, yet closely related documents. #7240 is more about showing how this large set of problems discussed in #5000 can all be solved technically, and how those solutions can be used together. It establishes that none of the proposed solutions for components of #5000 will preclude the possibility of other components being solved. What it does _not_ do however is drill too deeply on the user experience that will be built on top of those architectural changes. 

This doc on the other hand focuses more closely on a pair of scenarios, and establishes how those scenarios will work technically, and how they'll be exposed to the user.
@zadjii-msft
Copy link
Member

I'm gonna re-open this and stick it on the backlog, because the shield is almost certainly not what folks really wanted here.

@zadjii-msft zadjii-msft reopened this Jan 27, 2022
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. and removed Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. labels Jan 27, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Jan 27, 2022
@zadjii-msft zadjii-msft mentioned this issue Jan 27, 2022
Open
@zadjii-msft
Copy link
Member

Note to self:

gnome's new terminal, Console, does something like this - they auto-change the titlebar to be red when in sudo, and purple when ssh'd.

The ssh scenario is a GREAT example for another state to compound the problem space here (focused? x elevated? x ssh?) is now 8 states, not just 4.

@zadjii-msft zadjii-msft mentioned this issue Jun 8, 2022
Closed
@j4james j4james mentioned this issue Dec 22, 2022
Closed
@zadjii-msft zadjii-msft changed the title Suggestion: Enable default color scheme or theme based on elevation status Suggestion: Enable default theme based on elevation status Jan 3, 2023
@zadjii-msft zadjii-msft added the Area-Theming Anything related to the theming of elements of the window label Jan 3, 2023
@zadjii-msft
Copy link
Member

Promoting this as the theme-specific version, while #3246 is the scheme-specific one.

@carlos-zamora carlos-zamora mentioned this issue Feb 2, 2023
Open
@j4james j4james mentioned this issue Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-Theming Anything related to the theming of elements of the window Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @cessna048 @zadjii-msft