-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Rename tab" action removes focus from terminal #9160
Comments
@ArturGudiev - I see you got the newer version in the end 😊 |
@Don-Vito Yes🙂 |
## Summary of the Pull Request After rename ends (either by enter or escape) the rename box gets collapsed and the focus moves to the next tab stop in the TabView (e.g., new tab button). To overcome this: * Added RenameEnded event to TabHeaderControl * Forwarded it as RenamerDeactivated from TerminalTab * Registered in the TerminalPage to focus the active control upon RenamerDeactivated if focus didn't move to tab menu. This means, no matter how you close the renamer, the current terminal gains the focus. ## PR Checklist * [x] Closes #9160 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. (cherry picked from commit 00d1dc9)
🎉This issue was addressed in #9162, which has now been successfully released as Handy links: |
🎉This issue was addressed in #9162, which has now been successfully released as Handy links: |
Environment
Windows 10.0.18363.0
Steps to reproduce
Add the hotkey for the "rename tab" action in the settings
{ "command": "openTabRenamer", "keys": "ctrl+alt+r" },
Rename a tab using this hotkey
Expected behavior
A tab is renamed. The focus is still in the terminal.
Actual behavior
A tab is renamed. The focus is on the tabs panel.
The text was updated successfully, but these errors were encountered: