Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Health: apply [[nodiscard]] to functions that return status codes #951

Closed
binarycrusader opened this issue May 23, 2019 · 0 comments · Fixed by #953
Closed

Code Health: apply [[nodiscard]] to functions that return status codes #951

binarycrusader opened this issue May 23, 2019 · 0 comments · Fixed by #953
Assignees
@binarycrusader
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.

Comments

@binarycrusader
Copy link
Member

binarycrusader commented May 23, 2019 •
edited
Loading

Functions returning status codes should use [[nodiscard]] as mentioned recently by @adiviness.

They should also use noexcept, but that's a much more invasive change, so this issue is just about [[nodiscard]].
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 23, 2019
@binarycrusader binarycrusader self-assigned this May 23, 2019
@binarycrusader binarycrusader added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. labels May 23, 2019
@binarycrusader binarycrusader mentioned this issue May 23, 2019
Merged
5 tasks
@DHowett-MSFT DHowett-MSFT added Product-Meta The product is the management of the products. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 23, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 23, 2019
@ghost ghost closed this as completed in #953 May 30, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binarycrusader binarycrusader

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply [[nodiscard]] to functions returning error codes
2 participants
@binarycrusader @DHowett-MSFT