Apply [[nodiscard]] to functions returning error codes #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- applied [[nodiscard]] for all HRESULT, LRESULT, and NTSTATUS functions - fixed IntelliSense declaration complaints leading to function not implemented warnings - deleted declared but never implemented functions - fixed unused parameter warnings How verified: - bcz dbg - opencon - testcon - VS2019 debug build
binarycrusader
commented
May 23, 2019
zadjii-msft
reviewed
May 23, 2019
zadjii-msft
reviewed
May 23, 2019
There was a problem hiding this comment.
Seems good enough to me. Someone else (@miniksa) might hound you more on casting the HRESULT to void instead of LOG_IF_FAIL-ing, so I'm gonna let someone else make that call
miniksa
added
the
Area-CodeHealth
I've used WIL quite a bit, but never used the LOG_* macros so didn't think of applying them. Unless I hear otherwise, I'll assume that approach in the future, thanks. |
adiviness
suggested changes
May 23, 2019
ghost
added
Needs-Author-Feedback
- remove use of goto - make MakeAltRasterFont return void
adiviness
approved these changes
May 24, 2019
- remove vestigal function declarations - fix inconsistent function declaration
miniksa
approved these changes
May 30, 2019
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Functions returning status codes should use [[nodiscard]] as mentioned recently by @adiviness.
They should also use noexcept, but that's a much more invasive change, so this issue is just about [[nodiscard]].
References
#897
PR Checklist
Detailed Description of the Pull Request / Additional comments
implemented warnings
Please note I only checked for functions that had a declaration in a header file of some kind, so there might still be some functions only defined and used within .cpp files that don't have [[nodiscard]] applied.
How verified: