Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply [[nodiscard]] to functions returning error codes #953

Merged
3 commits merged into from
May 30, 2019
Merged

Apply [[nodiscard]] to functions returning error codes #953

3 commits merged into from
May 30, 2019

Commits on May 23, 2019

  1. Apply [[nodiscard]] to functions returning error codes 

    - applied [[nodiscard]] for all HRESULT, LRESULT, and NTSTATUS functions
- fixed IntelliSense declaration complaints leading to function not
  implemented warnings
- deleted declared but never implemented functions
- fixed unused parameter warnings

How verified:
- bcz dbg
- opencon
- testcon
- VS2019 debug build
    @binarycrusader
    binarycrusader committed May 23, 2019
    Configuration menu
    Copy the full SHA
    c6fc8d0 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. - use LOG_IF_FAILED where applicable 

    - remove use of goto
- make MakeAltRasterFont return void
    @binarycrusader
    binarycrusader committed May 24, 2019
    Configuration menu
    Copy the full SHA
    d750d5f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2019

  1. - add missing [[nodiscard]] 

    - remove vestigal function declarations
- fix inconsistent function declaration
    @binarycrusader
    binarycrusader committed May 25, 2019
    Configuration menu
    Copy the full SHA
    3085db3 View commit details
    Browse the repository at this point in the history