Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The user should be able to zoom a pane #996

Closed
zadjii-msft opened this issue May 24, 2019 · 5 comments · Fixed by #6989
Closed

The user should be able to zoom a pane #996

zadjii-msft opened this issue May 24, 2019 · 5 comments · Fixed by #6989
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.3

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented May 24, 2019 •
edited
Loading

The user should be able to zoom a pane, to make the pane take the entire size of the terminal window temporarily. Pressing the shortcut again on a zoomed pane will return to the unzoomed state
@zadjii-msft zadjii-msft added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 24, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 24, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 24, 2019
@zadjii-msft zadjii-msft mentioned this issue May 24, 2019
Open
59 tasks
@DHowett-MSFT DHowett-MSFT removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 24, 2019
@zadjii-msft zadjii-msft mentioned this issue Mar 2, 2020
Closed
This was referenced Mar 19, 2020
Closed
Closed
This was referenced May 1, 2020
Closed
Closed
@zadjii-msft zadjii-msft mentioned this issue Jun 4, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Jul 16, 2020
Closed
zadjii-msft added a commit that referenced this issue Jul 17, 2020
@zadjii-msft
This is a prototype for #996, pane zooming. There's some odd edge cas…
ec1aa26 
…es, but it works _pretty_ well
@zadjii-msft
Copy link
Member Author

Okay so one of the outstanding questions with this feature - how do we indicate to the user visually that the tab has a zoomed pane?

tmux does it with a Z in the window title:
image

I've heard it suggested that maybe we should manually enable the focus border around all the edges of the window. Personally, I hate that.
 

Maybe if we stuck this icon in the TabViewItem:

image E8A3 ZoomIn

we could either:

  • replace the tab's icon with the ZoomIn icon
  • Insert the ZoomIn icon at the start of the tab's name

Thoughts?

@zadjii-msft
Copy link
Member Author

Proof-of-concept:

zoom-pane-000

Need to document some methods and add comments throughout, but this is what we discussed in our team sync today. Note that the zooming takes a while because it's resizing and this is a debug build, so resizing is S L O W

@zadjii-msft zadjii-msft self-assigned this Jul 20, 2020
@zadjii-msft zadjii-msft mentioned this issue Jul 21, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 21, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 7, 2020
DHowett pushed a commit that referenced this issue Aug 7, 2020
@zadjii-msft
Add a togglePaneZoom action for zooming a pane (#6989)
70fd03f 
This PR adds the `togglePaneZoom` action, which can be used to make a
pane expand to fill the entire contents of the window.  A tab that
contains a zoomed pane will have a magnifying glass icon prepended
to its title. Any attempts to manage panes with one zoomed will force
the zoomed pane back to normal size.

VALIDATION
Zoomed in and out a bunch. Tried closing panes while zoomed. Tried
splitting panes while zoomed. Etc.

Closes #996
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 7, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #6989, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #6989, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #6989, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Add a togglePaneZoom action for zooming a pane microsoft/terminal
2 participants
@DHowett-MSFT @zadjii-msft