Hide _quake window on minimize ALWAYS

[zadjii-msft]

Summary of the Pull Request

This is a scoped implementation of "hide on minimize", only to the _quake window. When minimized, the _quake window won't appear in the taskbar. IT ALSO WON'T APPEAR IN THE TRAY, BECAUSE WE DON'T HAVE ONE YET.

I talked about this with @DHowett, and it seemed cool. Other windows will still minimize normally.

References

• Original thread: Feature request: hot key drop down ala quake/guake/tilda #653
• Spec: Spec for Quake Mode #9274
• megathread: [MEGATHREAD] Quake Mode & Global Summon #8888
• minimize to tray: [Feature-request] Minimize to tray #5727

PR Checklist

• Closes https://github.com/microsoft/terminal/projects/5#card-61246940
• I work here
• Tests added/passed
• Requires documentation to be updated - probably yea, but something _{something something}

Detailed Description of the Pull Request / Additional comments

After playing with it, it is in fact, cool.

ALSO LOG_IF_WIN32_BOOL_FALSE should DEFINITELY not be used with ShowWindow. ShowWindow returns false if the window was previously hidden, but doesn't SetLastError, so that macro will throw.

Validation Steps Performed

        { "keys": "ctrl+`", "command": { "action": "quakeMode" } },
        { "keys": "ctrl+1", "command": { "action": "globalSummon", "name": "_quake" } },
        // { "keys": "ctrl+1", "command": { "action": "globalSummon" } },
        // { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } },
        // { "keys": "ctrl+2", "command": { "action": "globalSummon", "toggleVisibility": false } },
        // { "keys": "ctrl+2", "command": { "action": "globalSummon", "dropdownDuration": 2000 } },
        { "keys": "ctrl+2", "command": { "action": "globalSummon", "monitor": "any" } },
        // { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } },
        { "keys": "ctrl+3", "command": { "action": "globalSummon", "monitor": "toMouse" } },
        // { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } },
        { "keys": "ctrl+4", "command": { "action": "globalSummon", "monitor": "toMouse", "dropdownDuration": 500 } },
        { "keys": "ctrl+5", "command": { "action": "globalSummon", "dropdownDuration": 500 } },

[DHowett]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download