Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind quakeMode to "win+`" by default #10122

Merged
1 commit merged into from
May 18, 2021
Merged

Bind quakeMode to "win+`" by default #10122

1 commit merged into from
May 18, 2021

Conversation

zadjii-msft
Copy link
Member

I'd personally chose to just bind globalSummon to win+`, but I do as I'm told.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 18, 2021
DHowett
DHowett approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't sound tooooooo salty ;P

@DHowett
Copy link
Member

DHowett commented May 18, 2021

@msftbot merge this in 8 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 18, 2021
@ghost
Copy link

ghost commented May 18, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 18 May 2021 21:35:40 GMT, which is in 8 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label May 18, 2021
@ghost ghost merged commit b5edb77 into main May 18, 2021
@ghost ghost deleted the dev/migrie/f/bind-quake-by-default branch May 18, 2021 22:56
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

@ASHWINI-GUPTA
Copy link

ASHWINI-GUPTA commented May 26, 2021 •
edited
Loading

Wanted to highlight PowerToys FancyZones has same default key binding Win + ` . Windows Terminal and PowerToys both are pouplar and will cause a conflict.

@zadjii-msft
Copy link
Member Author

@ASHWINI-GUPTA They actually changed their default, see: microsoft/PowerToys#10749

@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@leonMSFT leonMSFT leonMSFT approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zadjii-msft @DHowett @ASHWINI-GUPTA @leonMSFT