Correct Default Application Selector styles for high contrast and to change with OS theme dark/light toggle #10185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…medium color for light/dark and bind to ThemeResource so it changes with OS. Do not bind for High Contrast so it remains fully text-colored (white by default)
ghost
added
Area-Accessibility
DHowett
approved these changes
May 25, 2021
DHowett
added
the
zPreview-Service-Queued-1.13
miniksa
added
the
AutoMerge
|
Hello @miniksa! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 16 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
May 25, 2021
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Jun 1, 2021
…change with OS theme dark/light toggle (#10185) Correct Default Application Selector styles for high contrast and to change with OS theme dark/light toggle ## References - https://docs.microsoft.com/windows/uwp/design/controls-and-patterns/xaml-theme-resources ## PR Checklist * [x] Closes #10181 * [x] I work here * [x] Manual tests passed ## Detailed Description of the Pull Request / Additional comments 1. If I'm going to override colors, I need to define styles in a resource dictionary with Light, Dark, and HighContrast variants so it can be appropriate for each of those. 2. For HighContrast, I need to not mess with text colors and let them follow the default settings. 3. For using System Brushes, I need to use a `ThemeResource` binding not a `StaticResource` binding. The former lets it change when you flip the OS toggle Light/Dark. The latter is stuck to whatever it was when the page loaded. ## Validation Steps Performed - Loaded in light mode. Flipped to dark. Watched it change live. Checked both unselected and rollover/selected to ensure it was fine. - Loaded in dark mode. Flipped to light. Watched it change live. Checked both unselected and rollover/selected to ensure it was fine. - Flipped to HC. Watched it change live. Confirmed that unselected is black/white contrast and the roll over has the cyan/black. (No longer uses special second-line brush for HC, matches the controls I modeled this one on from OS Settings). (cherry picked from commit 43d5713)
DHowett
removed
the
zPreview-Service-Queued-1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct Default Application Selector styles for high contrast and to change with OS theme dark/light toggle
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
ThemeResourcebinding not aStaticResourcebinding. The former lets it change when you flip the OS toggle Light/Dark. The latter is stuck to whatever it was when the page loaded.Validation Steps Performed