Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edit button color in light theme #10412

Merged
1 commit merged into from
Jun 14, 2021
Merged

Fix edit button color in light theme #10412

1 commit merged into from
Jun 14, 2021

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Fixes a bug where the edit button in the actions page would have white text when in light theme. Now, we just fallback to XAML's built-in value (black in light theme and white in dark theme).

References

#6900 - Epic
Closes #10406

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. Area-Settings UI Anything specific to the SUI labels Jun 11, 2021
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Jun 11, 2021
@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jun 14, 2021
@ghost
Copy link

ghost commented Jun 14, 2021

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1fcfb61 into main Jun 14, 2021
@ghost ghost deleted the dev/cazamor/bugfix/edit-button-theming branch June 14, 2021 16:51
@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Jul 7, 2021
DHowett pushed a commit that referenced this pull request Jul 7, 2021
@carlos-zamora @DHowett
Fix edit button color in light theme (#10412)
febbf08 
## Summary of the Pull Request
Fixes a bug where the edit button in the actions page would have white text when in light theme. Now, we just fallback to XAML's built-in value (black in light theme and white in dark theme).

## References
#6900 - Epic
Closes #10406

(cherry picked from commit 1fcfb61)
@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 14, 2021
Closed
@ghost
Copy link

ghost commented Jul 14, 2021

🎉Windows Terminal Preview v1.10.1933.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@miniksa miniksa Awaiting requested review from miniksa

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pencil icon (Edit button) on Actions page is invisible with light theme
4 participants
@carlos-zamora @lhecker @PankajBhojwani @DHowett