Add the ability to toggle a pane's split direction #10713

Rosefield · 2021-07-19T22:06:27Z

Summary of the Pull Request

Add the ability to toggle a pane's split direction

Switch from horizontal to vertical split (and vice versa)
Propogate new borders through to children.

References

#10665

PR Checklist

Closes The ability to toggle the split direction of a pane #10665
CLA signed. If not, go over here and sign the CLA
Tests added/passed
Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
Schema updated.
I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Ran terminal, created multiple panes in different orientations, ran command through command palate and verified that they displayed properly in the new orientation.

Rosefield · 2021-07-20T17:11:38Z

I'm not sure what is up with the CI, everything builds fine and all of the tests appear to pass locally (there is a lot of noise in the output of Invoke-OpenConsoleTests so I'm not sure if a failure got hidden in the scrolling).

zadjii-msft

This one's pretty straightforward, thanks!

zadjii-msft · 2021-07-20T19:16:09Z

I kicked the CI, hopefully that'll pass. Otherwise, the fix should be in main now, merging with main should fix the issues.

- Switch from horizontal to vertical split (and vice versa) - Propogate new borders through to children.

Rosefield · 2021-07-21T18:37:23Z

@zadjii-msft This PR could also use a second reviewer. (Let me know if the pings are annoying, I'm not sure what the procedure should be.)

zadjii-msft · 2021-07-21T18:59:56Z

No worries. Sorry about any delays - a good portion of the team is out this week (and probably next week too), just as an fyi

Rosefield · 2021-07-21T19:21:09Z

Of course. I understand that everyone can be busy and have other priorities. I know that I've been a particularly demanding new contributor, too.

zadjii-msft · 2021-07-21T19:23:15Z

s/demanding/enthusiastic/g 😄

DHowett

Hey, thanks for this! I haven't done an in-depth review of the logic (sorry!), but one thing did catch my eye -- that's togglePaneSplit. Should we use something more like toggleSplitPaneOrientation or toggleSplitOrientation? My gut tells me that togglePaneSplit would change whether I'm allowed to split or not... but I'm happy to be vetoed here 😄

Rosefield · 2021-07-21T20:53:58Z

I am mildly in favor of keeping it as is (since I chose the name in the first place, obviously), but am happy to be convinced either way and can change it to the consensus. To me, at least, TogglePaneSplit is unambiguous and just a more terse version of Toggle[Pane]SplitOrientation since afaict there is no meaningful "you can[not] split this pane" action that could also exist. On the other hand I did write something to the effect of "split orientation" in many of the comments (but not in the command description). 🤷

zadjii-msft · 2021-07-22T13:31:58Z

IMO I like toggleSplitOrientation the best - togglePaneSplit kinda makes me think it's going to like, zoom the pane, or split it out into a new tab, or something like that.

or even togglePaneOrientation, or toggleSplitDirection. Jeez, naming is the hardest problem in CS

Rosefield · 2021-07-22T14:55:50Z

src/cascadia/TerminalSettingsModel/AllShortcutActions.h

+    ON_ALL_ACTIONS(PrevTab)                \
+    ON_ALL_ACTIONS(SendInput)              \
+    ON_ALL_ACTIONS(SplitPane)              \
+    ON_ALL_ACTIONS(ToggleSplitOrientation) \


You know, auto code formatting is nice, but sometimes it makes the diffs a bit annoying

Rosefield · 2021-07-22T14:57:22Z

I renamed all of the *PaneSplit items to be *SplitOrientation instead

…e-pane-split Conflicts: src/cascadia/TerminalSettingsModel/AllShortcutActions.h

Rosefield · 2021-07-22T17:02:29Z

Once again I am unsure what is up with the CI and its tests failing. I'm not seeing anything in the merge from main that should have broken the build.

zadjii-msft · 2021-07-22T17:06:49Z

Wow, you're just unlucky with those failures. The Feature Tests are rarely flaky, but they aren't perfect. You've just gotten a bad roll of test flakiness as of late.

ghost · 2021-08-02T21:04:26Z

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927

ghost · 2021-08-31T17:12:12Z

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

* Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Floris Westerman <me@floriswesterman.nl> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Nivaldo Tokuda <ni.h1@hotmail.com> Co-authored-by: David A. Sjøen <dasjoen@gmail.com> Co-authored-by: tharindu sathischandra <34299693+tharindusathis@users.noreply.github.com> Co-authored-by: Cutano <rinne@rinne.top>

* Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq * Add a guide for using OSC9;9 (#449) * I think this is everything we need. Pushing because I don't know if the image paths are right * This should fix the warnings * maybe fix the urls? * typos * Update TerminalDocs/tutorials/new-tab-same-directory.md Co-authored-by: Felix Christl <fchristl@gmail.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Felix Christl <fchristl@gmail.com> * Minor quake mode text update (#454) * DocuTune: Fix ms.topic values (#453) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Floris Westerman <me@floriswesterman.nl> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Nivaldo Tokuda <ni.h1@hotmail.com> Co-authored-by: David A. Sjøen <dasjoen@gmail.com> Co-authored-by: tharindu sathischandra <34299693+tharindusathis@users.noreply.github.com> Co-authored-by: Cutano <rinne@rinne.top> Co-authored-by: Felix Christl <fchristl@gmail.com> Co-authored-by: Alex Buck <abuck@microsoft.com>

* Add powerline redirect (#439) * Add redirect for old powerline page * Add vscode to gitignore * Main > Live (#448) * Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Floris Westerman <me@floriswesterman.nl> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Nivaldo Tokuda <ni.h1@hotmail.com> Co-authored-by: David A. Sjøen <dasjoen@gmail.com> Co-authored-by: tharindu sathischandra <34299693+tharindusathis@users.noreply.github.com> Co-authored-by: Cutano <rinne@rinne.top> * Toc update (#457) * Update to change equal symbol to plus key Addresses issue #196 *On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts. * change + to plus as shipped by default * Add notes about title change persistance * Update settings.json section * Link settings.json mentions * Fix links * fix a few more links * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/dynamic-profiles.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Update TerminalDocs/customize-settings/actions.md Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove repititious section * Added browser media keys (#371) * Add link to what is command line shell video (#377) * add intenseTextStyle to the docs (#381) * Multiple new pane features (#383) Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927 * wt.exe --window argument now available (#388) * Add notes that the `font` object is only 1.10+ (#389) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove MinimizeToTray action mentions (#387) * Docs updates for 1.11 release (#397) * Specify OS version availability for defterm (#417) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> * Remove tilde Reshttps://github.com/MicrosoftDocs/terminal/issues/260olves * Improve dup tab description #292 * Update minimizetotray setting to new name * Merge release 1.12 into master (#428) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> * Remove preview labels * Add redirect for old powerline page * Add vscode to gitignore * Config changes to reflect the default branch from master to main. * Add a note about the command palette to this doc (#447) * Add details about the command used to print the table (#446) * initialPos -> initialPosition (#445) * Add tip on extensions for configuration files (#440) * Add tip on extensions for configuration files Resolves #423 * fix numbering Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> * Corrected path (#434) The LocalAppData path was missing `{app-name}` * Update panes.md (#432) Minor edit on a shortcut key * Correct $PROFILE configuration (#431) When using winget, Oh-my-posh will not add Set-PoshPrompt to path, the execution will fail. The correct configuration can be found in https://ohmyposh.dev/docs/windows#replace-your-existing-prompt * Add a sample page (#444) * Add FAQ page (#442) * Add FAQ page * Finalize faq v1 * Replace md with yml, add toc * Update with settings UI feedback from kayla * fix image link * Fix preview faq * Add a guide for using OSC9;9 (#449) * I think this is everything we need. Pushing because I don't know if the image paths are right * This should fix the warnings * maybe fix the urls? * typos * Update TerminalDocs/tutorials/new-tab-same-directory.md Co-authored-by: Felix Christl <fchristl@gmail.com> Co-authored-by: Matt Wojciakowski <mattwoj@microsoft.com> Co-authored-by: Felix Christl <fchristl@gmail.com> * Minor quake mode text update (#454) * DocuTune: Fix ms.topic values (#453) Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Floris Westerman <me@floriswesterman.nl> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Nivaldo Tokuda <ni.h1@hotmail.com> Co-authored-by: David A. Sjøen <dasjoen@gmail.com> Co-authored-by: tharindu sathischandra <34299693+tharindusathis@users.noreply.github.com> Co-authored-by: Cutano <rinne@rinne.top> Co-authored-by: Felix Christl <fchristl@gmail.com> Co-authored-by: Alex Buck <abuck@microsoft.com> Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com> Co-authored-by: Floris Westerman <me@floriswesterman.nl> Co-authored-by: Mike Griese <migrie@microsoft.com> Co-authored-by: Schuyler Rosefield <Rosefield@users.noreply.github.com> Co-authored-by: Sean Jacobs <Sophismata@users.noreply.github.com> Co-authored-by: Leon Liang <lelian@microsoft.com> Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com> Co-authored-by: Pankaj Bhojwani <pabhojwa@microsoft.com> Co-authored-by: PankajBhojwani <pankaj.d.bhoj@gmail.com> Co-authored-by: Nivaldo Tokuda <ni.h1@hotmail.com> Co-authored-by: David A. Sjøen <dasjoen@gmail.com> Co-authored-by: tharindu sathischandra <34299693+tharindusathis@users.noreply.github.com> Co-authored-by: Cutano <rinne@rinne.top> Co-authored-by: Felix Christl <fchristl@gmail.com> Co-authored-by: Alex Buck <abuck@microsoft.com>

ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 19, 2021

zadjii-msft approved these changes Jul 20, 2021

View reviewed changes

Add the ability to toggle a pane's split direction

dc59348

- Switch from horizontal to vertical split (and vice versa) - Propogate new borders through to children.

Rosefield force-pushed the feature/gh10665-toggle-pane-split branch from a4fa0ae to dc59348 Compare July 20, 2021 19:59

DHowett reviewed Jul 21, 2021

View reviewed changes

Rename togglePaneSplit to toggleSplitOrientation

a051919

Rosefield commented Jul 22, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into feature/gh10665-toggl…

c4e20c7

…e-pane-split Conflicts: src/cascadia/TerminalSettingsModel/AllShortcutActions.h

zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Jul 22, 2021

ghost requested review from miniksa, carlos-zamora, leonMSFT, PankajBhojwani and lhecker July 22, 2021 15:20

Rosefield mentioned this pull request Jul 29, 2021

Move Pane to Tab (GH7075) #10780

Merged

6 tasks

lhecker approved these changes Aug 2, 2021

View reviewed changes

zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 2, 2021

ghost merged commit e710833 into microsoft:main Aug 2, 2021

Rosefield deleted the feature/gh10665-toggle-pane-split branch August 4, 2021 23:16

Rosefield added a commit to Rosefield/terminal-1 that referenced this pull request Aug 12, 2021

Multiple new pane features

1a37077

Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927

Rosefield mentioned this pull request Aug 12, 2021

Multiple new pane features MicrosoftDocs/terminal#383

Merged

cinnamon-msft pushed a commit to MicrosoftDocs/terminal that referenced this pull request Aug 30, 2021

Multiple new pane features (#383)

99626e6

Documentation for - microsoft/terminal#10713 - microsoft/terminal#10638 - microsoft/terminal#10780 - microsoft/terminal#10927

ghost mentioned this pull request Aug 31, 2021

The ability to toggle the split direction of a pane #10665

Closed

mattwojo mentioned this pull request Dec 10, 2021

Sync main and live (#458) MicrosoftDocs/terminal#459

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to toggle a pane's split direction #10713

Add the ability to toggle a pane's split direction #10713

Rosefield commented Jul 19, 2021

Rosefield commented Jul 20, 2021

zadjii-msft left a comment

zadjii-msft commented Jul 20, 2021

Rosefield commented Jul 21, 2021

zadjii-msft commented Jul 21, 2021

Rosefield commented Jul 21, 2021 via email •

edited by ghost

Loading

zadjii-msft commented Jul 21, 2021

DHowett left a comment

Rosefield commented Jul 21, 2021

zadjii-msft commented Jul 22, 2021 •

edited

Loading

Rosefield Jul 22, 2021

Rosefield commented Jul 22, 2021

Rosefield commented Jul 22, 2021

zadjii-msft commented Jul 22, 2021

ghost commented Aug 2, 2021

ghost commented Aug 31, 2021

Add the ability to toggle a pane's split direction #10713

Add the ability to toggle a pane's split direction #10713

Conversation

Rosefield commented Jul 19, 2021

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Rosefield commented Jul 20, 2021

zadjii-msft left a comment

Choose a reason for hiding this comment

zadjii-msft commented Jul 20, 2021

Rosefield commented Jul 21, 2021

zadjii-msft commented Jul 21, 2021

Rosefield commented Jul 21, 2021 via email • edited by ghost Loading

zadjii-msft commented Jul 21, 2021

DHowett left a comment

Choose a reason for hiding this comment

Rosefield commented Jul 21, 2021

zadjii-msft commented Jul 22, 2021 • edited Loading

Rosefield Jul 22, 2021

Choose a reason for hiding this comment

Rosefield commented Jul 22, 2021

Rosefield commented Jul 22, 2021

zadjii-msft commented Jul 22, 2021

ghost commented Aug 2, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Aug 31, 2021

Rosefield commented Jul 21, 2021 via email •

edited by ghost

Loading

zadjii-msft commented Jul 22, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.