Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist window layout on window close #10972

Merged
40 commits merged into from
Sep 8, 2021
Merged

Persist window layout on window close #10972

40 commits merged into from
Sep 8, 2021

Commits on Aug 18, 2021

  1. GH766 Persist tab layout on window close 

    - Add user setting for if tabs should be maintained (currently only supports the 1st window)
- Saves in the ApplicationState file a list of actions the terminal can perform to restore its layout.
    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    405c853 View commit details
    Browse the repository at this point in the history

  2. Add missing comment

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    6297417 View commit details
    Browse the repository at this point in the history

  3. Try to save pane color information

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    a265e81 View commit details
    Browse the repository at this point in the history

  4. formatting

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    48cde20 View commit details
    Browse the repository at this point in the history

  5. Also persist window size and location information

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    4b897d0 View commit details
    Browse the repository at this point in the history

  6. Remove state if the user manually closed all of their tabs (instead o… 

    …f closing the window specifically)
    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    773cc79 View commit details
    Browse the repository at this point in the history

  7. Capitalize to make the spellchecker happy?

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    37e5bd4 View commit details
    Browse the repository at this point in the history

  8. Also format. Again. Maybe Ill learn my lesson one of these days.

    @Rosefield
    Rosefield committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    1b6dfc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. Update setting name to better reflect what it actually does

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    c1722c7 View commit details
    Browse the repository at this point in the history

  2. Use inheritable settings correctly for the applied color scheme

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    d6997f9 View commit details
    Browse the repository at this point in the history

  3. Also save the tabs focused pane and zoom information

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    8c64dd5 View commit details
    Browse the repository at this point in the history

  4. Fix pane id calculation, save the correct split size

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    97bce32 View commit details
    Browse the repository at this point in the history

  5. Foiled by whitespace again.

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    ec79c93 View commit details
    Browse the repository at this point in the history

  6. hyphenation to appease the spell checker

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    d7ce2de View commit details
    Browse the repository at this point in the history

  7. Update comment on Pane::BuildStartupActions

    @Rosefield
    Rosefield committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    91c3d69 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Switch to serializing an array of window layouts so that the schema c… 

    …an stay the stay if we choose to have multiple windows saved in the future.
    @Rosefield
    Rosefield committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    ef80c66 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2021

  1. Add consts for json keys

    @Rosefield
    Rosefield committed Aug 22, 2021
    Configuration menu
    Copy the full SHA
    0a3ccd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. use consts in more places

    @Rosefield
    Rosefield committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    8d6a7ee View commit details
    Browse the repository at this point in the history

  2. Add to schema

    @Rosefield
    Rosefield committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    0a6d4f7 View commit details
    Browse the repository at this point in the history

  3. Save the correct location of the terminal.

    @Rosefield
    Rosefield committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    c0f7eaa View commit details
    Browse the repository at this point in the history

  4. Save if we are the only window open, instead of if we are the first w… 

    …indow only.
    @Rosefield
    Rosefield committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    2062eb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Code review changes. Also fix restoring position on startup.

    @Rosefield
    Rosefield committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    464ca59 View commit details
    Browse the repository at this point in the history

  2. even more formatting.

    @Rosefield
    Rosefield committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    3b02719 View commit details
    Browse the repository at this point in the history

  3. minor cleanup

    @Rosefield
    Rosefield committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d204f00 View commit details
    Browse the repository at this point in the history

  4. Put json converters in more reasonable places, improve the WindowLayo… 

    …ut ct converter.
    @Rosefield
    Rosefield committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    1cd14b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. try to move the actions more forcefully

    @Rosefield
    Rosefield committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    cfe3583 View commit details
    Browse the repository at this point in the history

  2. Switch to using a first window behavior setting (for future expansion… 

    …) instead of specific persist window layout setting.
    @Rosefield
    Rosefield committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    072822a View commit details
    Browse the repository at this point in the history

  3. code review: comments, better event handlers, and exception logging.

    @Rosefield
    Rosefield committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    b8b7d48 View commit details
    Browse the repository at this point in the history

  4. Try to more accurately detect if the user provided no commandline arg… 

    …s (we have a full default NewTab action)
    @Rosefield
    Rosefield committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    4b1bbbd View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Merge remote-tracking branch 'origin/main' into feature/gh766-persist… 

    …-tab-layout
    @Rosefield
    Rosefield committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    50cf7fb View commit details
    Browse the repository at this point in the history

  2. even merges arent safe from the formatter.

    @Rosefield
    Rosefield committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    81af065 View commit details
    Browse the repository at this point in the history

  3. remove old setting from the schema.

    @Rosefield
    Rosefield committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ef21ca6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into feature/gh766-persist… 

    …-tab-layout

 Conflicts:
	src/cascadia/TerminalSettingsModel/ApplicationState.cpp
	src/cascadia/TerminalSettingsModel/JsonUtils.h
    @Rosefield
    Rosefield committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ba56ded View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Make the NewTerminalArgs::Equals more like the other Equals implement… 

    …ations and less weird.
    @Rosefield
    Rosefield committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    6aeabb1 View commit details
    Browse the repository at this point in the history

  2. formatting

    @Rosefield
    Rosefield committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7f14c7d View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Add a feature flag to disable this feature in release.

    @Rosefield
    Rosefield committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    8e22231 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into feature/gh766-persist… 

    …-tab-layout

 Conflicts:
	src/cascadia/Remoting/WindowManager.h
	src/cascadia/Remoting/WindowManager.idl
    @Rosefield
    Rosefield committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    2f39ed9 View commit details
    Browse the repository at this point in the history

  3. formatting

    @Rosefield
    Rosefield committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    735de10 View commit details
    Browse the repository at this point in the history

  4. Code review: Make more things const that can be const

    @Rosefield
    Rosefield committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    230a1ab View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Initialize properties that were uninitialized

    @Rosefield
    Rosefield committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8f38e1b View commit details
    Browse the repository at this point in the history