Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a BreadcrumbBar to the SUI #12144

Merged
43 commits merged into from
Jan 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
0b58355
testing
PankajBhojwani Nov 2, 2021
ba4faec
got 2 styles that kinda work I guess
PankajBhojwani Nov 3, 2021
f3fd857
apparently this is the old expander
PankajBhojwani Nov 8, 2021
13bbcbf
just use muxc:expander
PankajBhojwani Nov 9, 2021
81d0c5c
remove remnants of previous implementation, format
PankajBhojwani Nov 9, 2021
61ae0a1
carlos comments
PankajBhojwani Nov 10, 2021
e6dffda
merge main
PankajBhojwani Jan 12, 2022
de8a869
format
PankajBhojwani Jan 12, 2022
26652fe
left align actions
PankajBhojwani Jan 20, 2022
cefa906
add more margin for scroll bar
PankajBhojwani Jan 20, 2022
79daeed
vertically center settings without help text
PankajBhojwani Jan 20, 2022
103d661
fix long text messing up setting container
PankajBhojwani Jan 20, 2022
5951399
fix font icon
PankajBhojwani Jan 21, 2022
0b7f77f
new toggle switch style
PankajBhojwani Jan 21, 2022
e20af2d
add reset buttons to setting container
PankajBhojwani Jan 25, 2022
f0f33c1
conflict
PankajBhojwani Jan 25, 2022
57f61dc
max width
PankajBhojwani Jan 26, 2022
aa7a95b
fix help text block width
PankajBhojwani Jan 26, 2022
6b032fd
combine rows and cols into one expander, still need to figure out hel…
PankajBhojwani Jan 27, 2022
a0b2fa1
conflict
PankajBhojwani Jan 27, 2022
afe4d1b
partway through
PankajBhojwani Dec 9, 2021
90453d3
breadcrumb part works
PankajBhojwani Jan 11, 2022
6958f93
remove Profiles.xaml, use RS strings for breadcrumbs
PankajBhojwani Jan 11, 2022
85b0b31
format, breadcrumb is a word now I guess
PankajBhojwani Jan 12, 2022
90b8366
rebase after merge main in base branch
PankajBhojwani Jan 12, 2022
2da46bb
breadcrumb as iinspectable instead
PankajBhojwani Jan 13, 2022
5680f48
helpers in main page
PankajBhojwani Jan 13, 2022
f776853
_Navigate now takes an optional label parameter for sub pages
PankajBhojwani Jan 14, 2022
cff990f
comment
PankajBhojwani Jan 14, 2022
c02fb81
use enums instead of strings
PankajBhojwani Jan 14, 2022
15197ff
macro
PankajBhojwani Jan 14, 2022
c2d0c21
align bcrumb bar differently
PankajBhojwani Jan 18, 2022
d5881e4
add chevron to buttons
PankajBhojwani Jan 19, 2022
7e90bf1
fix profile pages margins
PankajBhojwani Jan 20, 2022
579e07d
margin around font face box
PankajBhojwani Jan 20, 2022
3e53ef6
Additional settings header
PankajBhojwani Jan 20, 2022
db2208f
fix breadcrumb label
PankajBhojwani Jan 20, 2022
c42178d
remove things that are already in PVM
PankajBhojwani Jan 21, 2022
54eda74
conflict
PankajBhojwani Jan 25, 2022
9f672a7
format
PankajBhojwani Jan 25, 2022
20d34b5
update to new toggle switch
PankajBhojwani Jan 26, 2022
5d28a35
conflict
PankajBhojwani Jan 28, 2022
685a772
format
PankajBhojwani Jan 28, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/spelling/allow/allow.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ admins
apc
Apc
bsd
breadcrumb
breadcrumbs
calt
CMMI
ccmp
Expand Down
2 changes: 1 addition & 1 deletion src/cascadia/TerminalSettingsEditor/Appearances.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
HasSettingValue="{x:Bind Appearance.HasFontFace, Mode=OneWay}"
SettingOverrideSource="{x:Bind Appearance.FontFaceOverrideSource, Mode=OneWay}"
Visibility="{x:Bind Appearance.IsDefault, Mode=OneWay}">
<StackPanel>
<StackPanel Margin="0,8,0,0">
<!--
Binding the ItemsSource to a separate variable that switches between the
two font lists causes a crash within the ComboBox code.
Expand Down
78 changes: 78 additions & 0 deletions src/cascadia/TerminalSettingsEditor/CommonResources.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,85 @@

</VisualStateManager.VisualStateGroups>
</Grid>
</ControlTemplate>
</Setter.Value>
</Setter>
</Style>

<Style x:Key="ToggleButtonStyle"
TargetType="ToggleButton">
<Setter Property="Background" Value="{ThemeResource ExpanderHeaderBackground}" />
<Setter Property="MinWidth" Value="{ThemeResource FlyoutThemeMinWidth}" />
<Setter Property="MinHeight" Value="64" />
<Setter Property="BorderThickness" Value="{ThemeResource ExpanderHeaderBorderThickness}" />
<Setter Property="BorderBrush" Value="{ThemeResource ExpanderHeaderBorderBrush}" />
<Setter Property="Padding" Value="16,0,8,0" />
<Setter Property="Margin" Value="0,4,8,0" />
<Setter Property="HorizontalAlignment" Value="Stretch" />
<Setter Property="CornerRadius" Value="{ThemeResource ControlCornerRadius}" />
<Setter Property="VerticalAlignment" Value="Stretch" />
<Setter Property="HorizontalContentAlignment" Value="Left" />
<Setter Property="Template">
<Setter.Value>
<ControlTemplate TargetType="ToggleButton">
<Grid x:Name="Grid"
Padding="{TemplateBinding Padding}"
AutomationProperties.AccessibilityView="Raw"
Background="{TemplateBinding Background}"
BorderBrush="{TemplateBinding BorderBrush}"
BorderThickness="{TemplateBinding BorderThickness}"
CornerRadius="{TemplateBinding CornerRadius}">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*" />
<ColumnDefinition Width="Auto" />
</Grid.ColumnDefinitions>
<ContentPresenter x:Name="ContentPresenter"
Grid.Column="0"
HorizontalContentAlignment="{TemplateBinding HorizontalContentAlignment}"
VerticalContentAlignment="{TemplateBinding VerticalContentAlignment}"
Content="{TemplateBinding Content}"
ContentTemplate="{TemplateBinding ContentTemplate}"
ContentTransitions="{TemplateBinding ContentTransitions}" />
<FontIcon Margin="20,0,8,0"
HorizontalAlignment="Right"
FontSize="10"
FontWeight="Black"
Glyph="&#xE76C;" />

<VisualStateManager.VisualStateGroups>
<VisualStateGroup x:Name="CommonStates">
<VisualState x:Name="Normal" />
<VisualState x:Name="PointerOver">
<Storyboard>
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="Grid"
Storyboard.TargetProperty="Background">
<DiscreteObjectKeyFrame KeyTime="0"
Value="{ThemeResource ToggleButtonBackgroundPointerOver}" />
</ObjectAnimationUsingKeyFrames>
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="Grid"
Storyboard.TargetProperty="BorderBrush">
<DiscreteObjectKeyFrame KeyTime="0"
Value="{ThemeResource ToggleButtonBorderBrushPointerOver}" />
</ObjectAnimationUsingKeyFrames>
</Storyboard>
</VisualState>
<VisualState x:Name="Pressed">
<Storyboard>
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="Grid"
Storyboard.TargetProperty="Background">
<DiscreteObjectKeyFrame KeyTime="0"
Value="{ThemeResource ToggleButtonBackgroundPressed}" />
</ObjectAnimationUsingKeyFrames>
<ObjectAnimationUsingKeyFrames Storyboard.TargetName="Grid"
Storyboard.TargetProperty="BorderBrush">
<DiscreteObjectKeyFrame KeyTime="0"
Value="{ThemeResource ToggleButtonBorderBrushPressed}" />
</ObjectAnimationUsingKeyFrames>
</Storyboard>
</VisualState>
</VisualStateGroup>
</VisualStateManager.VisualStateGroups>
</Grid>
</ControlTemplate>
</Setter.Value>
</Setter>
Expand Down
Loading