Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus box around color schemes combo box #12439

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Fix focus box around color schemes combo box #12439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75881d1
Add small margin
PankajBhojwani Feb 8, 2022
42d827e
Format
PankajBhojwani Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@
Spacing="24">

<!-- Select Color and Add New Button -->
<StackPanel Orientation="Horizontal">
<StackPanel Margin="0,5,0,0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also moves the whole box down -- OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very slightly! The page doesn't look any different from the other pages though (and it is going to be overhauled very soon anyway)

Orientation="Horizontal">

<StackPanel Orientation="Horizontal"
Visibility="{x:Bind local:Converters.InvertedBooleanToVisibility(IsRenaming), Mode=OneWay}">
Expand Down