Fix font axes/features not working on DPI change

[PankajBhojwani]

When the dpi is changed, call updateFont() instead of TriggerFontChange, this
means that we continue to use the existing font features/axes

Closes #11287

[lhecker]

I believe this issue is easier to fix if you replace this:

terminal/src/cascadia/TerminalControl/ControlCore.cpp

Lines 927 to 929 in 349b767

	_renderer->TriggerFontChange(::base::saturated_cast<int>(dpi),
	_desiredFont,
	_actualFont);

with this:

_updateFont();

An additional benefit would be that it's easier to reason about our application state if all font related changes go through _updateFont. Currently only DPI changes don't make use of that function in ControlCore which seems kinda weird to me.

Oh and this bug probably also exists for AtlasEngine... Using _updateFont would fix it for both.

[PankajBhojwani]

@lhecker's suggestion makes a lot more sense, PR has been updated to use updateFont() instead (and confirmed that the fix works)

[ghost]

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[lhecker]

@PankajBhojwani This fixes #11317 now, which is why I've modified your commit message.
The fix for #11317 isn't perfect, because the window gets elongated horizontally when the DPI changes, but I believe that's another bug...

[DHowett]

From chat:

nevermind, it doesn't fix it ;P

[ghost]

🎉Windows Terminal v1.12.1073 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉Windows Terminal Preview v1.13.1073 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download