Setting for hide window when it loses focus

[davidegiacometti]

Summary of the Pull Request

Added setting for for hide window when it loses focus.
Works on normal window and quake window.

References

PR Checklist

• Closes Terminal should be able to auto-minimize on focus lost #10660
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

• Enable Settings > Appearance > Automatically hide window
• Terminal window should be minimized on taskbar when it loses focus
• Quake window should be minimized on system tray when it loses focus
• Enable also Settings > Appearance > Hide Terminal in the notification area when it is minimized
• Terminal window should be minimized on system tray when it loses focus
• Quake window should be minimized on system tray when it loses focus

[zadjii-msft]

Thanks for whipping this up!

This is gonna sound super annoying, but I actually envisioned this as a setting that's not only restricted to the quake window. Like, I'd bet there are plenty of folks that want their non _quake windows to also minimize on focus lost.

Ultimately, that would mostly mean the following changes to this PR:

1. A super tedious string replace to replace most of the autoHideQuakeWindow with autoHideWindow
2. (trickier): Right now, you just call HideWindow, which SW_HIDEs the window. For the quake window, that's fine, cause the quake window always hides on minimize. For other windows, that might not always work. We don't want to hide these windows unless minimizeToNotificationArea is also enabled.

That would let this setting affect any window, regardless of whether you're in the quake window or not. Now, there's more discussion to be had over if we should opt the quake window into this behavior by default (like we do for focus mode, etc). I'm leaning no, with us relying on #9992 for enabling separate window-name-settings. But I'm also open to discussion on this one.

Does that all make sense? If not, I can try and clarify. Overall, the code looks great. It's plumbed through all the right layers, it's in the settings UI, everythink here is otherwise :chef_kiss:

[davidegiacometti]

Thank you @zadjii-msft
I was trying to figure out if this setting had to affect quake window only: does it make sense to minimize to taskbar or system tray the normal terminal window when it lose focus? I will update the PR if this is the wanted behaviour.

EDIT: I have updated the PR. Works with both window (normal Terminal and quake) and also consider the tray icon setting.

[zadjii-msft]

easy-button.jpg

Thanks for nearing with us! This looks great to me. You're gonna make a lot of people happy 😄

[ghost]

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[jvincent-siplay]

Hi, is it possible to enable this only for quake windows? I'd like my normal windows to act normal (minimize to taskbar, no auto-minimize) and just my quake window to auto-hide when it loses focus.

[zadjii-msft]

@jvincent-siplay at the moment, no. We're tracking that in #9992.

[ghost]

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[pas-de-2]

I don't understand the logic of why this should effect normal terminal windows. Auto hiding is non-standard behavior for windowed applications, while at the same time it makes little sense why a Quake console should stay open on losing focus. Either option as its currently configured ends up compromising the other for normal use cases.