Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show number of search results & positions of hits in scrollbar #14045

Merged
merged 80 commits into from
Sep 5, 2023
Merged

Show number of search results & positions of hits in scrollbar #14045

merged 80 commits into from
Sep 5, 2023

Commits on Dec 14, 2020

  1. Introduce search status

    @Don-Vito
    Don-Vito committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    fa06c6f View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Teach search box to update status when new output is written

    @Don-Vito
    Don-Vito committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ff1558c View commit details
    Browse the repository at this point in the history

  2. Remove live-search feature flag

    @Don-Vito
    Don-Vito committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5391f4e View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. Merge remote-tracking branch 'upstream/main' into 6319-search-status

    @Don-Vito
    Don-Vito committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    81a4a31 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. Allow disabling navigation buttons in SearchBox

    @Don-Vito
    Don-Vito committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    4ab4d41 View commit details
    Browse the repository at this point in the history

  2. Add Searching status to translation

    @Don-Vito
    Don-Vito committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    4a2de19 View commit details
    Browse the repository at this point in the history

  3. Run search in the background + itnroduce grace for next search

    @Don-Vito
    Don-Vito committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    fe59504 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Merge branch 'main' into 6319-search-status

    @Don-Vito
    Don-Vito committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    1068f85 View commit details
    Browse the repository at this point in the history

  2. Introduce computation of required statusbox width

    @Don-Vito
    Don-Vito committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    8e5efb7 View commit details
    Browse the repository at this point in the history

  3. Reduce the value :)

    @Don-Vito
    Don-Vito committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    160716d View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Merge branch 'pull/8588' into dev/migrie/fhl/search-results 

    Co-authored-by: Don-Vito <khvitaly@gmail.com>
    @zadjii-msft @Don-Vito
    zadjii-msft and Don-Vito committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f87a988 View commit details
    Browse the repository at this point in the history

  2. move the code around. It works again, bug... the buttons don't work a… 

    …t all??
    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    85f1bb7 View commit details
    Browse the repository at this point in the history

  3. That was silly of me

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    bc5bf1e View commit details
    Browse the repository at this point in the history

  4. for all your dead code removal needs, call 0118 999 881 999 119 725 3

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    a3c1d8a View commit details
    Browse the repository at this point in the history

  5. pips in the scrollbar

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    8ae9e39 View commit details
    Browse the repository at this point in the history

  6. KB focus works again

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    3f39b5b View commit details
    Browse the repository at this point in the history

  7. throttledfunc, for good and for profit

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ec0ae7d View commit details
    Browse the repository at this point in the history

  8. cleanup

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f61c080 View commit details
    Browse the repository at this point in the history

  9. this seems to work well enough

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    5cf5ccd View commit details
    Browse the repository at this point in the history

  10. making the scrollbar more sensible

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    d437420 View commit details
    Browse the repository at this point in the history

  11. rename slightly for convention's sake

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    e4e603d View commit details
    Browse the repository at this point in the history

  12. update the pips if the first hit is in the viewport

    @zadjii-msft
    zadjii-msft committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    57913e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    bcbce34 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. This is a test fix, because now we send notifications even for circling

    @zadjii-msft
    zadjii-msft committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e49e13e View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    195fc67 View commit details
    Browse the repository at this point in the history

  2. POC: remove yielding for fun and for profit

    @zadjii-msft
    zadjii-msft committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    f396d36 View commit details
    Browse the repository at this point in the history

  3. KISS, you're welcome leonard

    @zadjii-msft
    zadjii-msft committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    da1e89f View commit details
    Browse the repository at this point in the history

  4. why _was_ that optional

    @zadjii-msft
    zadjii-msft committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    198b3cf View commit details
    Browse the repository at this point in the history

  5. Migrate spelling-0.0.21 changes from main

    @DHowett
    DHowett committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    03f81b2 View commit details
    Browse the repository at this point in the history

  6. runformat

    @zadjii-msft
    zadjii-msft committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    953d87b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    9e6b97c View commit details
    Browse the repository at this point in the history

  2. this doesn't fail locally. Maybe it got fixed in the merge with main?

    @zadjii-msft
    zadjii-msft committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    28a71b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. -Wall

    @zadjii-msft
    zadjii-msft committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    2dc5683 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev/migrie/fhl/search-marks' of https://github.com/micr… 

    …osoft/terminal into dev/migrie/fhl/search-marks
    @zadjii-msft
    zadjii-msft committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    49c729a View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Merge branch 'main' into dev/migrie/fhl/search-marks

    @zadjii-msft
    zadjii-msft committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    5509a96 View commit details
    Browse the repository at this point in the history

  2. oops missed this merge conflict

    @zadjii-msft
    zadjii-msft committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    b288f5d View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    ebdc887 View commit details
    Browse the repository at this point in the history

  2. some minor review nits

    @zadjii-msft
    zadjii-msft committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    09eb0a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    5360d68 View commit details
    Browse the repository at this point in the history

  2. PR nits

    @zadjii-msft
    zadjii-msft committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e4056ca View commit details
    Browse the repository at this point in the history

  3. the codeformat check should just commit the fix itself >__<

    @zadjii-msft
    zadjii-msft committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    28bce48 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    af77652 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5906372 View commit details
    Browse the repository at this point in the history

  3. this'll do

    @zadjii-msft
    zadjii-msft committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c2f36cc View commit details
    Browse the repository at this point in the history

  4. I think this is probably unreasonably cheecky

    @zadjii-msft
    zadjii-msft committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    aa47308 View commit details
    Browse the repository at this point in the history

  5. audit mode more

    @zadjii-msft
    zadjii-msft committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    876d4fa View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge branch 'main' into dev/migrie/fhl/search-marks

    @zadjii-msft
    zadjii-msft committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6b650d7 View commit details
    Browse the repository at this point in the history

  2. format

    @zadjii-msft
    zadjii-msft committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d707096 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    bc315b1 View commit details
    Browse the repository at this point in the history

  2. resave resw in VS

    @zadjii-msft
    zadjii-msft committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    fd77061 View commit details
    Browse the repository at this point in the history

  3. PR notes

    @zadjii-msft
    zadjii-msft committed Aug 14, 2023
    2 Configuration menu
    Copy the full SHA
    c97721c View commit details
    Browse the repository at this point in the history

  4. this formatter man

    @zadjii-msft
    zadjii-msft committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    b1107de View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0a1568d View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Use ICU for text search

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    462b8d2 View commit details
    Browse the repository at this point in the history

  2. Improve documentation

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    a346a2a View commit details
    Browse the repository at this point in the history

  3. Spelling fix

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    dba1629 View commit details
    Browse the repository at this point in the history

  4. Fix a bug and x86 woes

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8146ecd View commit details
    Browse the repository at this point in the history

  5. More x86 woes, Improve UiaTextRangeBase

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    5ca26aa View commit details
    Browse the repository at this point in the history

  6. Fix unit tests

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e0fb764 View commit details
    Browse the repository at this point in the history

  7. Implement backwards text iteration

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ecc735d View commit details
    Browse the repository at this point in the history

  8. Address feedback

    @lhecker
    lhecker committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    56c7911 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Address feedback

    @lhecker
    lhecker committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c731eae View commit details
    Browse the repository at this point in the history

  2. Address feedback, Use namespaces

    @lhecker
    lhecker committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ca4ec38 View commit details
    Browse the repository at this point in the history

  3. Spelling fix

    @lhecker
    lhecker committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d53d4bd View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Remove selection coloring from Search

    @lhecker
    lhecker committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1e527c4 View commit details
    Browse the repository at this point in the history

  2. Address Dustin's feedback

    @lhecker
    lhecker committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1fc01d8 View commit details
    Browse the repository at this point in the history

  3. Optimize GetReadableColumnCount

    @lhecker
    lhecker committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7cccf56 View commit details
    Browse the repository at this point in the history

  4. Fix AuditMode failures

    @lhecker
    lhecker committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    362693b View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into dev/migrie/search-v2-v3

    @zadjii-msft
    zadjii-msft committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    1fb4331 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev/migrie/fhl/search-marks' into dev/migrie/search-v2-v3

    @zadjii-msft
    zadjii-msft committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c1d1f63 View commit details
    Browse the repository at this point in the history

  7. It's so much nicer

    @zadjii-msft
    zadjii-msft committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d3e69f7 View commit details
    Browse the repository at this point in the history

  8. 🚧 dead code construction crew

    @zadjii-msft
    zadjii-msft committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    574f30b View commit details
    Browse the repository at this point in the history

  9. 🚧 dead code construction crew part 2

    @zadjii-msft
    zadjii-msft committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    198decc View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/search-v2-v3

    @zadjii-msft
    zadjii-msft committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    444398d View commit details
    Browse the repository at this point in the history

  2. update scrollbar as we scroll the buffer

    @zadjii-msft
    zadjii-msft committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    971e7c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. DRIVE-BY: Fix a potential crash in Search with 0 results

    @zadjii-msft
    zadjii-msft committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5da6ceb View commit details
    Browse the repository at this point in the history

  2. notes

    @zadjii-msft
    zadjii-msft committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    4413534 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/search… 

    …-marks
    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3e42162 View commit details
    Browse the repository at this point in the history

  2. don't prealloc the results vector just to toss it

    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b22e5c1 View commit details
    Browse the repository at this point in the history

  3. nits

    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    bd2f240 View commit details
    Browse the repository at this point in the history