Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vintage opacity on Windows 10 #14481

Merged
4 commits merged into from
Dec 9, 2022

Conversation

zadjii-msft
Copy link
Member

This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in KB5011831[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one question on _runtimeUseAcrylic

src/cascadia/UnitTests_Control/ControlCoreTests.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalControl/ControlCore.cpp Show resolved Hide resolved
@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Dec 5, 2022
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Dec 9, 2022
@ghost ghost requested review from PankajBhojwani, DHowett and lhecker December 9, 2022 18:46
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that_was_easy_button_xy7MRuvL.jpg

Can you project this up for servicing back to the right versions?

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 9, 2022
@ghost
Copy link

ghost commented Dec 9, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit a5c5b8a into main Dec 9, 2022
@ghost ghost deleted the dev/migrie/b/vintage-opacity-for-everyone branch December 9, 2022 20:50
DHowett pushed a commit that referenced this pull request Dec 12, 2022
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176746
Service-Version: 1.16
DHowett pushed a commit that referenced this pull request Dec 12, 2022
This reverts #11372 and #11285, and brings #11180 to everyone, now that MSFT:37879806 has been serviced to everyone in [KB5011831](https://support.microsoft.com/en-gb/topic/april-25-2022-kb5011831-os-builds-19042-1682-19043-1682-and-19044-1682-preview-fe4ff411-d25a-4185-aabb-8bc66e9dbb6c)[1].

I tested this on my home Win10 laptop that's super old and doesn't have a functioning clock, but it does have that update at the very least.

I don't think we had an issue tracking this?

[1]: I'm pretty sure about this at least

(cherry picked from commit a5c5b8a)
Service-Card-Id: 87176745
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal v1.15.3465.0 and v1.15.3466.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off zBugBash-Consider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants