Make the Pane inactive border respect the theme.window.applicationTheme
#14486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
ghost
requested review from
DHowett
approved these changes
Dec 9, 2022
| @@ -4175,6 +4175,22 @@ namespace winrt::TerminalApp::implementation | |||
| const auto theme = _settings.GlobalSettings().CurrentTheme(); | |||
| auto requestedTheme{ theme.RequestedTheme() }; | |||
|
|
|||
| { | |||
| // Update the brushes that Pane's use... | |||
| Pane::SetupResources(requestedTheme); | |||
There was a problem hiding this comment.
Scary, updating globals like that, but I think I get how it is safe!
Co-authored-by: Carlos Zamora <carlos.zamora@microsoft.com>
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't do this before, because
App::Current().Resources().Lookup()would always return the OS theme version of a resource. That thread has lengthy details on why.FORTUNATELY FOR US, this isn't the first time we've dealt with this. We've come up with a workaround in the past, and we can just use it again here.
Closes #3917
This will also make #3061 easy 😉