Add support for running the Terminal without _any_ windows #14944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing AppLogic that I hate so I'm gonna start over
This reverts commit a5255ba.
We'll need this for #5000, for ainulindale. This refactoring will be annoying enough as it is so we may as well do it as a first, separate PR.
…ns though, so it immediately exits
…ndale # Conflicts: # src/cascadia/WindowsTerminal/AppHost.h
…XAML island is started. I think this can work in the parent at least
…It launches and crashes immediately. We'll keep shuffling code.
At this point, I determined that I would need to make some big changes to AppHost and decided that it was time to commit before moving on.
…pressive It exits itself after 30s, but hey it worked
(cherry picked from commit 57d1dd4)
Doesn't work with multiple windows open, but doesn't do _nothing_ (cherry picked from commit 427a4a5)
…ut this doesn't fix the crash (cherry picked from commit 700aadc)
TerminalPage is the thing that ends up expanding iterable Command. It does this largely with copies - it makes a new map, a new vector, copies the Commands over, and does the work there before setting up the cmdpal. Except, it's not making a copy of the Commands, it's making a copy of the vector, with winrt objects all pointing at the Command objects that are ultimately owned by CascadiaSettings. This doesn't matter if there's only one TerminalPage - we'll only ever do that once. If there's many, on different threads, then one tpage will end up expanding the subcommands of one Command while another tpage is ALSO iterating on those subcommands. Hence why I'm getting `hresult_changed_state`s (cherry picked from commit 2122eec)
36 TODOs
…ispatcher. 35 TODOs left
32 TODOs
30 TODOs left
Each page was registering as a handoff target, so basically we'd start the server then yeet the connection back to the first window and presto, you'd have a dead window and a connection on the wrong thread and everything was awful. Instead, only register as the handoff listener when we've actually said we want to be a handoff listener.
…lindale # Conflicts: # src/cascadia/TerminalApp/AppLogic.cpp # src/cascadia/TerminalApp/AppLogic.h # src/cascadia/TerminalApp/AppLogic.idl # src/cascadia/TerminalApp/TerminalPage.h # src/cascadia/TerminalApp/TerminalWindow.cpp # src/cascadia/TerminalApp/TerminalWindow.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp # src/cascadia/TerminalSettingsModel/GlobalAppSettings.h # src/cascadia/TerminalSettingsModel/GlobalAppSettings.idl # src/cascadia/WindowsTerminal/AppHost.cpp # src/cascadia/WindowsTerminal/AppHost.h
…to dev/migrie/oop/3/feanor-and-the-unchaining-of-melkor
zadjii-msft
added
Product-Terminal
carlos-zamora
approved these changes
Mar 20, 2023
…or-and-the-unchaining-of-melkor
zadjii-msft
added a commit
that referenced
this pull request
Mar 24, 2023
PankajBhojwani
requested changes
Mar 31, 2023
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
…or-and-the-unchaining-of-melkor
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
|
@PankajBhojwani I was starting to roll together a "Compatibility" page for the SUI that has that (and other things we've talked about in the past), so I was gonna leave it out for now? |
PankajBhojwani
approved these changes
Apr 5, 2023
zadjii-msft
deleted the
dev/migrie/oop/3/feanor-and-the-unchaining-of-melkor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a setting (
compatibility.allowHeadless) to let the Terminal keep running even when all windows are closed. This lets hotkeys keep working, because the Emperor thread is still running, just, without any windows.I'm really tempted to invoke the magic "closes" word on #9996, but honestly, we should also add some sort of support for
wt --headlessorwt --hiddenor whatever, before we close that. There's also #13630 which seems imminently doable.Tested manually. I'd post a gif of "close all terminal windows, then invoke the quakeMode binding and *presto*, but that would be an unnecessarily big gif.
Related to #9996 but not enough to close it if you ask me