Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VsDevCmdGenerator: respect the user's startingDirectory #15035

Merged
merged 2 commits into from
Mar 23, 2023
Merged

VsDevCmdGenerator: respect the user's startingDirectory #15035

merged 2 commits into from
Mar 23, 2023

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 23, 2023

The PowerShell equivalent was added in the initial pull request, #7774.

Closes #13721

@DHowett
VsDevCmdGenerator: respect the user's startingDirectory
a5b06b4 
The PowerShell equivalent was added in the initial pull request, #7774.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 23, 2023
@DHowett DHowett mentioned this pull request Mar 23, 2023
Closed
@github-actions

This comment has been minimized.

Sign in to view
lhecker
lhecker approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startdir startdir startdir startdir

@DHowett DHowett merged commit f06cd17 into main Mar 23, 2023
@DHowett DHowett deleted the dev/duhowett/vsdevcmd-nostartdir branch March 23, 2023 23:14
DHowett added a commit that referenced this pull request Mar 31, 2023
@DHowett
VsDevCmdGenerator: respect the user's startingDirectory (#15035)
d6d3561 
The PowerShell equivalent was added in the initial pull request, #7774.

Closes #13721

(cherry picked from commit f06cd17)
Service-Card-Id: 88719282
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

startingDirectory and splitMode ignored in settings file
3 participants
@DHowett @lhecker @zadjii-msft