#1363 - Campbell color scheme should change the foreground color from #F2F2F2 to #CCCCCC #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the foreground color from #F2F2F2 to #CCCCCC.
|
Just leaving this for you @DHowett-MSFT. This is the change as discussed in the bug. You had it set to tag Help-Wanted, so I just put it together. The work is there if you want to take it. |
|
Thanks! If you’re up to it, you could do a whole color palette sweep and get solarized in there as well. What do you think? #1509 |
miniksa
approved these changes
Jun 26, 2019
DHowett-MSFT
approved these changes
Jun 29, 2019
DHowett-MSFT
pushed a commit
that referenced
this pull request
Jul 2, 2019
Changed the foreground color from #F2F2F2 to #CCCCCC so that ESC[1m _actually_ brightens it. (cherry picked from commit f63cada)
DHowett-MSFT
pushed a commit
that referenced
this pull request
Jul 2, 2019
Changed the foreground color from #F2F2F2 to #CCCCCC so that ESC[1m _actually_ brightens it. (cherry picked from commit f63cada)
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 2, 2019
Changed the foreground color from #F2F2F2 to #CCCCCC so that ESC[1m _actually_ brightens it.
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the foreground color from #F2F2F2 to #CCCCCC.
Summary of the Pull Request
I changed where foreground is set in CascadiaSettings.cpp, from #F2F2F2 : RGB(242, 242, 242) to #CCCCCC : RGB(204, 204, 204).
References
PR Checklist
added/passedN/ADetailed Description of the Pull Request / Additional comments
As detailed in the bug, this slightly reduces the brightness of the default/foreground color of the Campbell color scheme from BrightWhite to White. This then allows the use of ESC sequence codes to add an intensity bit to make White display as BrightWhite. Without this change, using ESC[1m would keep the display color the same.
Validation Steps Performed
This was tested by manipulating the profiles.json to find the correct values to use. The code change was not tested outside this commit because it is a direct replacement of hard coded data, so there are no behavioral changes which should need to be evaluated separately.