Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pile of 'experimental' settings to the profile SUI #16809

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

zadjii-msft
Copy link
Member

As noted in #3337, we never actually added this menu to the settings.

Since we're planning on taking this out of "experimental" in 1.21, we should have a visible setting for it too.

@DHowett
Copy link
Member

DHowett commented Mar 4, 2024

nit: reword commit title to be imperative ("this commit will...")

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 4, 2024
@zadjii-msft zadjii-msft changed the title adds a pile of 'experimental' settings to the profile SUI Add a pile of 'experimental' settings to the profile SUI Mar 4, 2024
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits on the resw. Approving since it'll be a quick fix.

@zadjii-msft zadjii-msft merged commit b9a0cae into main Mar 21, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/add-missing-experimental-prof-settings branch March 21, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants