Stop parsing saveSnippets actions in json
#17535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the spec review, we agreed these didn't really need to be saved to the user's own settings file. This removes parsing and saving for the `experimental.saveSnippet` action, but we still have the action _internally_. This is powered by a new x-macro for "INTERNAL_" actions. Follow-up from #16513.
lhecker
approved these changes
Jul 9, 2024
|
Doesn’t this suggest that actions aren’t the right currency for this? Sorta like tab tearoff… |
DHowett
approved these changes
Jul 9, 2024
|
This also renames |
carlos-zamora
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spec review, we agreed these didn't really need to be saved to the user's own settings file. This removes parsing and saving for the
experimental.saveSnippetaction, but we still have the action internally. This is powered by a new x-macro for "INTERNAL_" actions.Follow-up from #16513.