Make fire_and_forget exception safe #17783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
DHowett
approved these changes
Aug 23, 2024
carlos-zamora
approved these changes
Aug 23, 2024
Comment on lines
-703
to
+705
| winrt::fire_and_forget TermControl::UpdateControlSettings(IControlSettings settings) | ||
| void TermControl::UpdateControlSettings(IControlSettings settings) | ||
| { | ||
| return UpdateControlSettings(settings, _core.UnfocusedAppearance()); | ||
| UpdateControlSettings(settings, _core.UnfocusedAppearance()); |
There was a problem hiding this comment.
📝 This is really the only change in this PR that isn't winrt::fire_and_forget --> safe_void_coroutine. Should be fine though.
carlos-zamora
approved these changes
Aug 23, 2024
zadjii-msft
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
/me re-names this til::fire_and_forget
i can't be the only one that enjoyed the mental imagery of "fire and forget". very clear meaning IMO
I'll be curious to see what exceptions we're just gonna ignore now and how the side-effects will end up propagating to future code that executes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clones
winrt::fire_and_forgetand replaces the uncaughtexception handler with one that logs instead of terminating.
My hope is that this removes one source of random crashes.
Validation Steps Performed
I added a
THROW_HRtoTermControl::UpdateControlSettingsbefore and after the suspension point and ensured the application
won't crash anymore.