Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to make the build work again #2945

Merged
merged 6 commits into from
Sep 30, 2019
Merged

Attempt to make the build work again #2945

merged 6 commits into from
Sep 30, 2019

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Sep 27, 2019 •
edited
Loading

  • Remove sourcelink because it's not compatible with 16.3 and causes multiwrite on the PDB issues
    (this can be alleviated slightly by calling /FS despite the fact that we were already calling /MP which was supposed to imply /FS)
  • Stop parallel builds because apparently they're toast now
  • Halt the new warning C26814 because we haven't solved it yet and it's brand new
  • Add references and dependencies to projects that are missing them that were apparently fine with 16.2 but not 16.3

@miniksa miniksa changed the title Revert "Add source linking information during the build (#2857)" Attempt to make the build work again. Then go drink because VS16.3 has driven me to it Sep 27, 2019
@miniksa miniksa changed the title Attempt to make the build work again. Then go drink because VS16.3 has driven me to it Attempt to make the build work again Sep 27, 2019
@miniksa
Disable new rule C26814 as it's breaking builds
c944de7 
Wrote a follow up task #2941 to roll it out later.
@miniksa
Copy link
Member Author

miniksa commented Sep 28, 2019

Welp, some test in the unit tests is now hanging indefinitely and not returning causing that task to not finish. I don't know what it is, but I have to leave.

@miniksa miniksa marked this pull request as ready for review September 28, 2019 01:26
@DHowett-MSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

zadjii-msft
zadjii-msft approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 🍻 :shipit:

@DHowett-MSFT DHowett-MSFT merged commit 52534c9 into master Sep 30, 2019
@DHowett-MSFT DHowett-MSFT deleted the dev/miniksa/buuuuh branch September 30, 2019 17:39
DHowett-MSFT pushed a commit that referenced this pull request Oct 1, 2019
@DHowett
Revert "Combined changes to make the build work again (see inside) (#…
05cbffe 
…2945)"

This reverts commit 52534c9.
@miniksa miniksa mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniksa @DHowett-MSFT @zadjii-msft