Fix issue where text copied to clipboard doesn't have line endings

[d-bingham]

Summary of the Pull Request

References

PR Checklist

• Closes Copy and paste from the Windows Terminal doesn't include line breaks #1073
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Fixes issue with console text copied to the clipboard not having correct line endings.

It appears the primary cause of the problem was the text erase code was using the default setting of the wrapped-text flag -- that is, when it erased lines (or the whole screen), it cleared cells up until the end of the line, and without end-of-line wrapping explicitly disabled, the rows with erased text all thought there was a wrapped line because the last cell in each row was written to...

Validation Steps Performed

1. Open up a Terminal window (for this example, a WSL instance)
2. Hit enter a couple of times to generate some duplicates of the prompt to copy/paste
3. Select multiple lines, copy, paste to Notepad
4. Note that the lines include line breaks as expected
5. Clear the terminal by the clear command
6. Hit enter a couple of times to generate some prompts
7. Select multiple lines, copy, paste to Notepad
   8a) Note that in the unmodified version of Terminal, these lines have no line breaks
   8b) Note that in the patched version of Terminal, line breaks exist

[DHowett-MSFT]

!!!

@carlos-zamora this fits in with our understanding of the world, right? we fixed the same bug in conhost, but forgot to propagate that fix to windows terminal? :O

[DHowett-MSFT]

Of course! Our fixes conspired against eachother. #2831 plus #2797!

[carlos-zamora]

My bad. This is what happens when you work on two very similar bugs in two very similar projects at very similar times. Thanks for submission! @DHowett-MSFT and @miniksa can we get this in for 0.6 plz?

[DHowett-MSFT]

Yep this is tagged in for 0.6

[stevenh]

Thanks this fix!

It seemed totally random, sometimes worked some times didn't, thought I was going mad ;-)

Do you have an ETA on 0.6 release, as would love to get a fix for this.

[miniksa]

@stevenh, we're trying to get 0.6 out next week. Hopefully Tuesday. Might slip a day or two since we've got a bunch of folks on vacation or sick.

[conioh]

Does this also fix the window resize bug?

[ghost]

🎉Windows Terminal Preview v0.6.2951.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[guillemcanal]

Hi, I made a test just this morning and it don't seems to work. Please find attached a short clip of the issue. CRLF don't seems to be replaced by LF in when text is pasted into WindowsTerminal.

[DHowett-MSFT]

This bug report is about copying. Your bug report is about pasting. There’s already a hundred reports of that on this tracker. Thanks!

[guillemcanal]

This bug report is about copying. Your bug report is about pasting. There’s already a hundred reports of that on this tracker. Thanks!

Oh! I didn't quite get the meaning of the issue as explained by @d-bingham. I feel sorry about that. Thanks for clarifying ;)