Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the x64 hosted tools when building on x64 #4956

Merged
1 commit merged into from
Mar 25, 2020
Merged

Conversation

DHowett-MSFT
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT commented Mar 17, 2020

This commit may help with the compiler and linker running out of memory.

@miniksa
Copy link
Member

miniksa commented Mar 17, 2020

Doesn't look like it did much to me. But it might keep us from hitting those occasional "the linker gave up" bugs on x64...

@zadjii-msft zadjii-msft added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. labels Mar 19, 2020
@DHowett-MSFT DHowett-MSFT changed the title Figure out if the x64 hosted tools make our build better or worse Switch to the x64 hosted tools when building on x64 Mar 23, 2020
@DHowett-MSFT DHowett-MSFT marked this pull request as ready for review March 23, 2020 17:17
@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 25, 2020
@ghost
Copy link

ghost commented Mar 25, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 48480e6 into master Mar 25, 2020
@ghost ghost deleted the dev/duhowett/what-if branch March 25, 2020 15:47
DHowett-MSFT pushed a commit that referenced this pull request Apr 14, 2020
)

This commit may help with the compiler and linker running out of memory.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants