Properly represent block selections in UIA #4991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Mar 18, 2020
DHowett-MSFT
approved these changes
Mar 18, 2020
|
@msftbot merge this in 5 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
DHowett-MSFT
pushed a commit
that referenced
this pull request
Apr 14, 2020
## Summary of the Pull Request Block selections were always read and displayed as line selections in UIA. This fixes that. ## PR Checklist * [x] Closes #4509 ## Detailed Description of the Pull Request / Additional comments 1. Expose `IsBlockSelection()` via IUiaData 2. Update the constructor to be able to take in a block selection parameter 3. Make ScreenInfoUiaProviders pass step 1 output into step 2 constructor 4. Update all instances of `UiaTextRange::GetTextRects()` to include this new flag ## Validation Steps Performed Manually tested. Additional tests would be redundant as GetTextRects() is tested in the text buffer.
5 tasks
ghost
pushed a commit
that referenced
this pull request
Apr 17, 2020
The scroll locking rework that landed with the DxRenderer's partial invalidation change introduced a deadlock. UIA locks the buffer for reading before asking it to scroll (which now requires a write lock.) Scrolling is probably _okay_ to have a little bit of torn state that might arise from us unlocking the read lock early before triggering the write lock down the line. While investigating this, I also noticed that our bounding rects stopped being viewport-relative (and were instead buffer-relative.) That regressed with the switch to `GetTextRects` in #4991 ## PR Checklist * [ ] Closes (issues noticed in investigating the DPI changes) * [x] CLA signed. * [ ] Tests added/passed * [ ] Requires documentation to be updated * [x] Core contributor badge ## Validation Steps Performed Manual pass with inspect.exe
|
🎉 Handy links: |
ghost
mentioned this pull request
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Block selections were always read and displayed as line selections in UIA. This fixes that.
PR Checklist
Detailed Description of the Pull Request / Additional comments
IsBlockSelection()via IUiaDataUiaTextRange::GetTextRects()to include this new flagValidation Steps Performed
Manually tested.
Additional tests would be redundant as GetTextRects() is tested in the text buffer.