Add support for fullscreen launchMode
#6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unchMode-fullscreen
…nch" This reverts commit 46e5196.
ghost
added
Area-Settings
tikkss
added a commit
to tikkss/dotfiles
that referenced
this pull request
May 21, 2020
本当はフルスクリーンモードが良いが（タブの表示領域が不要なので） 現状、フルスクリーンモードの設定がない。 プルリクエストは出されているようなので、とりあえず最大化で凌ぐことにした。 [Add support for fullscreen `launchMode` by zadjii-msft · Pull Request #6060 · microsoft/terminal · GitHub](microsoft/terminal#6060)
carlos-zamora
requested changes
May 21, 2020
| @@ -143,6 +143,7 @@ void IslandWindow::_HandleCreateWindow(const WPARAM, const LPARAM lParam) noexce | |||
| } | |||
|
|
|||
| ShowWindow(_window.get(), nCmdShow); | |||
|
|
|||
There was a problem hiding this comment.
nit: you could probably remove this change
ghost
added
the
Needs-Author-Feedback
shit absolutely, I didn't realize I was on 16.6 when I committed/pushed this branch 😬 |
ghost
removed
the
Needs-Author-Feedback
ghost
requested review from
DHowett
approved these changes
May 21, 2020
3 tasks
|
@carlos-zamora unblock me pls 😄 |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
May 28, 2020
jelster
pushed a commit
to jelster/terminal
that referenced
this pull request
May 28, 2020
## Summary of the Pull Request Adds `"launchMode": "fullscreen"`, which does what it says on the box. ## PR Checklist * [x] Closes microsoft#288 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments It's important to let the winow get created, _then_ fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying.
ghost
pushed a commit
that referenced
this pull request
Jun 1, 2020
## Summary of the Pull Request Adds two new flags to the `wt.exe` alias: * `--maximized,-M`: Launch the new Terminal window maximized. This flag cannot be combined with `--fullscreen`. * `--fullscreen,-F`: Launch the new Terminal window fullscreen. This flag cannot be combined with `--maximized`. ## References * This builds on the work done in #6060. * The cmdline args megathread: #4632 ## PR Checklist * [x] Closes #5801 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments * I had to move the commandline arg parsing up a layer from `TerminalPage` to `AppLogic`, because `AppLogic` controls the Terminal's settings, including launch mode settings. This seems like a reasonable change, to put both the settings from the file and the commandline in the same place. - **Most of the diff is that movement of code** * _"What happens when you try to pass both flags, like `wtd -M -F new-tab`?"_:  ## Validation Steps Performed * Ran a bunch of commandlines to see what happened.
This was referenced Jun 12, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds
"launchMode": "fullscreen", which does what it says on the box.PR Checklist
Detailed Description of the Pull Request / Additional comments
It's important to let the winow get created, then fullscreen it, because otherwise, when the user exits fullscreen, the window is sized to like, 0x0 or something, and that's just annoying.