Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSC8 termination over the PTY after SGR 0 #7608

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fix OSC8 termination over the PTY after SGR 0 #7608

merged 1 commit into from
Sep 11, 2020

Conversation

PankajBhojwani
Copy link
Contributor

@ghost ghost added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty Severity-Blocking We won't ship a release like this! No-siree. labels Sep 11, 2020
@DHowett DHowett changed the title Fixing osc8 bug #7597 Fix OSC8 termination over the PTY after SGR 0 Sep 11, 2020
@DHowett DHowett merged commit 88d1527 into master Sep 11, 2020
@DHowett DHowett deleted the dev/pabhoj/osc8_fix branch September 11, 2020 18:00
@ghost
Copy link

ghost commented Sep 22, 2020

🎉Windows Terminal Preview v1.4.2652.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Conpty For console issues specifically related to conpty Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An empty OSC8 followed by an SGR 0 fails to terminate hyperlink over ConPTY at the bottom of the screen (!)
4 participants
@PankajBhojwani @DHowett @carlos-zamora @miniksa