Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show color slider in Tab color picker #7963

Merged
1 commit merged into from Oct 23, 2020
Merged

Show color slider in Tab color picker #7963

1 commit merged into from Oct 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2020 •
edited by ghost
Loading

Adds the color slider to the tab color picker

PR Checklist

Validation Steps Performed

Not required

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Oct 19, 2020
@ghost ghost mentioned this pull request Oct 19, 2020
Closed
@WSLUser
Copy link
Contributor

WSLUser commented Oct 19, 2020 •
edited
Loading

Please change OP to say "works-around" instead of closes the issue. Also, this might require a doc update in https://docs.microsoft.com/en-us/windows/terminal/tips-and-tricks under Color a tab - Tip. The MS Terminal team can decide that. I would add Use the hex field or color slider and also add a warning about setting the hex field to black #00000.

@ghost
Copy link
Author

ghost commented Oct 19, 2020

Ok @WSLUser

@DHowett
Copy link
Member

DHowett commented Oct 19, 2020

@alannt777 Speaking as a maintainer of this project: you were correct to say that it closes #7948, because the user-visible behavior as seen from terminal will be addressed. 😄

@WSLUser's discussion points are likely more applicable to the upstream bug on microsoft-ui-xaml, which will need documentation in their doc group.

@DHowett
Copy link
Member

DHowett commented Oct 19, 2020

As an aside: it's not generally helpful to ping individual team members for new reviews or issues. Every one of us gets every action taken on this repo as an e-mail. If the review's been around for a while (more than 4 hours is a good start) and you've got specific reviewer comments and you'd like to "bring somebody back", it is then appropriate to tag them. 😁

@DHowett
Copy link
Member

DHowett commented Oct 19, 2020

Thanks for the contribution, and for catching the misconfiguration to begin with!

@ghost
Copy link
Author

ghost commented Oct 20, 2020 •
edited by ghost
Loading

@alannt777 Speaking as a maintainer of this project: you were correct to say that it closes #7948, because the user-visible behavior as seen from terminal will be addressed. 😄

That makes sense. Also, now I can choose the how light and how dark a color is without a hex or an RGB value!

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main October 22, 2020 00:26
@zadjii-msft zadjii-msft self-assigned this Oct 22, 2020
zadjii-msft
zadjii-msft approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this is way better, thanks!

@zadjii-msft zadjii-msft removed their assignment Oct 23, 2020
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 23, 2020
@ghost
Copy link

ghost commented Oct 23, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 4a95d94 into microsoft:main Oct 23, 2020
DHowett pushed a commit that referenced this pull request Oct 27, 2020
@DHowett
Show color slider in Tab color picker (#7963)
b2c521a 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
Adds the color slider to the tab color picker

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #7948
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] ~Tests added/passed~
* [ ] ~Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx~
* [ ] ~Schema updated.~
* [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #7948

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

*Not required*

(cherry picked from commit 4a95d94)
@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal v1.4.3141.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Nov 11, 2020

🎉Windows Terminal Preview v1.5.3142.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met hacktoberfest-accepted Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to set custom tab color after setting it to black
3 participants
@WSLUser @DHowett @zadjii-msft