Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command palette accessibility #9143

Merged
1 commit merged into from
Feb 17, 2021
Merged

Fix command palette accessibility #9143

1 commit merged into from
Feb 17, 2021

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Feb 12, 2021 •
edited by DHowett
Loading

Fixes a regression of command palette accessibility. The regression was
introduced in #8377 by setting IsTabStop to false. Though the commands
would light up, the focus didn't technically get on the command, so the
screen reader would just read the text box.

Validation Steps Performed

Opened the command palette while NVDA is active. It now reads the
commands as focus moves on them.

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. Area-CmdPal Command Palette issues and features labels Feb 12, 2021
@carlos-zamora
Copy link
Member Author

@Don-Vito mind taking a look here? Want to make sure I'm not breaking any of the work you've done with the command palette.

@Don-Vito
Copy link
Contributor

I think we removed the tabstops when making the palette ephemeral. Since then we made the mechanism more robust (using visual tree traversing to detect focus loss), so this change should be ok. Yet I will try to play with a palette later on, to see it doesn't close itself or something 😄

@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Feb 17, 2021
@ghost ghost requested review from miniksa, leonMSFT and PankajBhojwani February 17, 2021 17:41
@ghost ghost requested a review from DHowett February 17, 2021 21:30
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Feb 17, 2021
@ghost
Copy link

ghost commented Feb 17, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ac3e4bf into main Feb 17, 2021
@ghost ghost deleted the dev/cazamor/a11y/bugfix-cmd-plt branch February 17, 2021 21:30
DHowett
DHowett approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the changes and the bot responded by resetting my review ...

@ghost ghost removed the Needs-Second It's a PR that needs another sign-off label Feb 17, 2021
@DHowett DHowett added zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. and removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Feb 23, 2021
DHowett pushed a commit that referenced this pull request Feb 23, 2021
@carlos-zamora @DHowett
Fix command palette accessibility (#9143)
7541b71 
Fixes a regression of command palette accessibility. The regression was
introduced in #8377 by setting `IsTabStop` to false. Though the commands
would light up, the focus didn't technically get on the command, so the
screen reader would just read the text box.

Opened the command palette while NVDA is active. It now reads the
commands as focus moves on them.

(cherry picked from commit ac3e4bf)
@ghost
Copy link

ghost commented Mar 1, 2021

🎉Windows Terminal v1.6.10571.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 1, 2021

🎉Windows Terminal Preview v1.7.572.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Accessibility Issues related to accessibility Area-CmdPal Command Palette issues and features AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlos-zamora @Don-Vito @DHowett @zadjii-msft