Add validation to make sure operation params reference models availab…

…le in the current version (#4179)

fix [#3920](#3920)
fix [#3134](#3134)

.chronus/changes/fix-validate-op-params-2024-7-13-19-39-34.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@typespec/versioning"
+---
+
+Add validation to make sure operation params reference models available in the current version

.chronus/changes/fix-validate-op-params-2024-7-13-19-39-35.md

@@ -0,0 +1,8 @@
+---
+# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
+changeKind: fix
+packages:
+  - "@typespec/versioning"
+---
+
+Add validation to make sure types referencing array in union types have compatible versioning.

packages/versioning/src/validate.ts

@@ -112,6 +112,21 @@ export function $onValidate(program: Program) {
         for (const sourceModel of op.parameters.sourceModels) {
           validateReference(program, op, sourceModel.model);
         }
+
+        for (const prop of op.parameters.properties.values()) {
+          // Validate op -> property have correct versioning
+          validateTargetVersionCompatible(program, op, prop, {
+            isTargetADependent: true,
+          });
+
+          // Validate model property -> type have correct versioning
+          const typeChangedFrom = getTypeChangedFrom(program, prop);
+          if (typeChangedFrom !== undefined) {
+            validateMultiTypeReference(program, prop);
+          } else {
+            validateReference(program, prop, prop.type);
+          }
+        }
       },
       interface: (iface) => {
         for (const source of iface.sourceInterfaces) {
@@ -511,20 +526,20 @@ function validateReference(program: Program, source: Type, target: Type) {
   if ("templateMapper" in target) {
     for (const param of target.templateMapper?.args ?? []) {
       if (isType(param)) {
-        validateTargetVersionCompatible(program, source, param);
+        validateReference(program, source, param);
       }
     }
   }
 
   switch (target.kind) {
     case "Union":
       for (const variant of target.variants.values()) {
-        validateTargetVersionCompatible(program, source, variant.type);
+        validateReference(program, source, variant.type);
       }
       break;
     case "Tuple":
       for (const value of target.values) {
-        validateTargetVersionCompatible(program, source, value);
+        validateReference(program, source, value);
       }
       break;
   }

packages/versioning/test/incompatible-versioning.test.ts

@@ -540,6 +540,20 @@ describe("versioning: validate incompatible references", () => {
     });
   });
 
+  describe("operations", () => {
+    it("emit diagnostic when unversioned parameter type is a versioned model", async () => {
+      const diagnostics = await runner.diagnose(`
+        @added(Versions.v2)
+        model Foo {}
+
+        op test(param: Foo): void;
+      `);
+      expectDiagnostics(diagnostics, {
+        code: "@typespec/versioning/incompatible-versioned-reference",
+      });
+    });
+  });
+
   describe("complex type references", () => {
     it("emit diagnostic when using versioned model as template argument in non versioned property", async () => {
       const diagnostics = await runner.diagnose(`
@@ -584,6 +598,17 @@ describe("versioning: validate incompatible references", () => {
       });
     });
 
+    it("emit diagnostic when using versioned union variant of array in non versioned source", async () => {
+      const diagnostics = await runner.diagnose(`
+        @added(Versions.v2)
+        model Versioned {}
+        op test(): Versioned[] | string;
+      `);
+      expectDiagnostics(diagnostics, {
+        code: "@typespec/versioning/incompatible-versioned-reference",
+      });
+    });
+
     it("emit diagnostic when using versioned tuple element in nin versioned operation return type", async () => {
       const diagnostics = await runner.diagnose(`
         @added(Versions.v2)