Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow backslash (windows path) in cadl config #1261

Open
timotheeguerin opened this issue Nov 11, 2022 · 4 comments · Fixed by #4023
Open

Disallow backslash (windows path) in cadl config #1261

timotheeguerin opened this issue Nov 11, 2022 · 4 comments · Fixed by #4023
Assignees
@timotheeguerin
Milestone
Backlog

Comments

@timotheeguerin
Copy link
Member

Feel like there has been cases where this was done and caused issues.

Even though it could maybe work this make it always a bad experience having to escape \ and not being able to copy outside of windows.
Think it would just be easier to force using / for paths in config.(Emit a diagnostic)
@ghost ghost added the Needs Triage label Nov 11, 2022
@timotheeguerin timotheeguerin added design:needed A design request has been raised that needs a proposal and removed Needs Triage labels Nov 14, 2022
@timotheeguerin timotheeguerin self-assigned this Nov 14, 2022
@markcowl markcowl removed the design:needed A design request has been raised that needs a proposal label Nov 16, 2022
@markcowl
Copy link
Contributor

est: 3

@markcowl markcowl modified the milestones: [2023] January, [2023] March Dec 5, 2022
@markcowl markcowl modified the milestones: [2023] March, Backlog Jan 28, 2023
@timotheeguerin timotheeguerin self-assigned this Jul 25, 2024
@timotheeguerin timotheeguerin mentioned this issue Jul 25, 2024
Merged
@markcowl markcowl added the breaking-change A change that might cause specs or code to break label Jul 30, 2024
@markcowl
Copy link
Contributor

Adding the breaking change label, as this could cause new diagnostics for existing specs

@markcowl markcowl modified the milestones: Backlog, [2024] August Jul 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 5, 2024
@timotheeguerin
Warn when using windows style path separator (#4023)
d15af24 
fix [#1261](#1261)

Using windows style separator can cause issue when trying to run a spec
on a non windows platform on top of being a pain to work with(escaping)

This PR adds validation to config element that are already validated as
`absolute-path` to also check they unix a unix style of path
@timotheeguerin
Copy link
Member Author

This was reverted as it applied to the CLI as well this is a problem #4173

@timotheeguerin timotheeguerin modified the milestones: [2024] August, Backlog Aug 13, 2024
@timotheeguerin timotheeguerin removed the breaking-change A change that might cause specs or code to break label Aug 13, 2024
@timotheeguerin
Copy link
Member Author

for this to work we need the cli to be able to resolve what emitter optins are ahead of time so it can call resolvePath to both resolve them relative to cwd and replace windows \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Warn when using windows style path separator timotheeguerin/typespec
3 participants
@bterlson @timotheeguerin @markcowl