[Bug]: tsp install breaks on latest version of node

[LadyCailin]

Describe the bug

> node --version
v20.12.2
> tsp install
TypeSpec compiler v0.53.1

tsp install

Install TypeSpec dependencies

Options:
  --help     Show help                                                 [boolean]
  --debug    Output debug log messages.               [boolean] [default: false]
  --pretty   Enable color and formatting in TypeSpec's output to make compiler e
             rrors easier to read.                     [boolean] [default: true]
  --version  Show version number                                       [boolean]

Error: spawn EINVAL
    at ChildProcess.spawn (node:internal/child_process:421:11)
    at spawn (node:child_process:761:9)
    at installTypeSpecDependencies (file:///C:/Users/.../node_modules/@typespec/compiler/dist/src/core/install.js:4:19)
    at file:///C:/Users/.../node_modules/@typespec/compiler/dist/src/core/cli/cli.js:157:95
    at Object.handler (file:///C:/Users/.../node_modules/@typespec/compiler/dist/src/core/cli/utils.js:16:16)
    at file:///C:/Users/caismith/.../node_modules/yargs/build/lib/command.js:206:54
    at maybeAsyncResult (file:///C:/Users/.../node_modules/yargs/build/lib/utils/maybe-async-result.js:9:15)
    at CommandInstance.handleValidationAndGetResult (file:///C:/Users/.../node_modules/yargs/build/lib/command.js:205:25)
    at CommandInstance.applyMiddlewareAndGetResult (file:///C:/Users/.../node_modules/yargs/build/lib/command.js:245:20)
    at CommandInstance.runCommand (file:///C:/Users/.../node_modules/yargs/build/lib/command.js:128:20) {
  errno: -4071,
  code: 'EINVAL',
  syscall: 'spawn'
}

According to nodejs/node#52554 this is an security fix in the latest version of node.

Reproduction

1. Download NodeJS Version v18.20.2, v20.12.2, v21.7.3
2. Run tsp install

Checklist

• Follow our Code of Conduct
• Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[LadyCailin]

There are a couple of other places that this is probably also broken, but I have not traced the code enough to test it: legacy-helper.js, utils.js, and common.ts, as well as some test files. legacy-helper.js specifically mentions this being intentionally not used because "it causes other issues". However, tsp install is probably the most urgent of these fixes.

[timotheeguerin]

yeah we especially were not calling shell: true and having hardcoded mapping of the windows vs linux executable name to we wouldn't have to deal with escaping parameters. I'll investigate if there is a better way or we will need to do that